Allow field getters to return a std::shared_ptr<const response::Value> #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where copying elements between
service::ResolverResult
documents and converting toresponse::Value
adds a lot of overhead, field getters can now hold on to a pre-convertedstd::shared_ptr<const response::Value>
and return that. TheModifiedResult
andFieldResult
will prefer that over a value ofT
orstd::future<T>
, andresponse::Value
can now perform copy-on-write from astd::shared_ptr<const response::Value>
, so it doesn't need to repeat any conversion or copying to keep returning the sameshared_ptr
.