Merge graphintrospection lib back into graphqlservice #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, I split code which was only referenced by schemas generated without
schemagen --no-introspection
into a separate library calledgraphqlintrospection
. At some point, I ended up adding references to every cpp/object file ingraphqlintrospection
tographqlservice
and the schemas generated byschemagen
(mostly for request validation support). Even though a schema build withschemagen --no-introspection
doesn't expose the__schema
or__type
field resolvers, it still needs to know about built-in types and use them for validation. The dependency was hidden in all of thenointrospection
tests by the part of CMakeLists.txt which added a dependency fromgraphqljson
ongraphqlintrospection
.It's simplest overall to just merge
graphqlintrospection
back intographqlservice
. The build requirements are less complicated both internally and for consumers. This should be source-compatible with schemas/services built withv4.0.*
, but since it will probably require a change to the build system for consumers, I'm also bumping the minor version tov4.1.0
.