Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge graphintrospection lib back into graphqlservice #197

Merged
merged 3 commits into from
Jan 7, 2022

Conversation

wravery
Copy link
Contributor

@wravery wravery commented Jan 7, 2022

Originally, I split code which was only referenced by schemas generated without schemagen --no-introspection into a separate library called graphqlintrospection. At some point, I ended up adding references to every cpp/object file in graphqlintrospection to graphqlservice and the schemas generated by schemagen (mostly for request validation support). Even though a schema build with schemagen --no-introspection doesn't expose the __schema or __type field resolvers, it still needs to know about built-in types and use them for validation. The dependency was hidden in all of the nointrospection tests by the part of CMakeLists.txt which added a dependency from graphqljson on graphqlintrospection.

It's simplest overall to just merge graphqlintrospection back into graphqlservice. The build requirements are less complicated both internally and for consumers. This should be source-compatible with schemas/services built with v4.0.*, but since it will probably require a change to the build system for consumers, I'm also bumping the minor version to v4.1.0.

@wravery wravery linked an issue Jan 7, 2022 that may be closed by this pull request
@wravery wravery merged commit 99fbc63 into microsoft:main Jan 7, 2022
@wravery wravery deleted the merge-libs branch January 7, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphqlservice target no longer works without graphqlintrospection
1 participant