Accept either a Base64 encoded binary or an opaque string in response::IdType #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up/alternative to #229. Instead of making it all or nothing at compile time, individual fields can either return a
std::vector<std::uint8_t>(Base64 encoded bytes) or astd::string(opaque string with no encoding) inresponse::IdType. There's also a newresponse::Type::IDenum entry, and aValue::maybe_id()method to test if it's safe to callValue::get<IdType>()orValue::release<IdType>().Since this may require some minor updates to existing code, I bumped the minor version number to 4.2.0.