Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Update node types #327

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Update node types #327

merged 1 commit into from
Apr 7, 2021

Conversation

orta
Copy link
Contributor

@orta orta commented Apr 6, 2021

There's churn on the npm package-lock because it's jumping between v1 and v2 (e.g. someone else is using npm 7 and I'm using npm6 ) it doesn't really matter too much

This repo's master branch CI is failing because the 12 branch of node doesn't have Serializable in a way it used to

https://github.com/microsoft/dtslint/commits/master

node_modules/@definitelytyped/utils/dist/process.d.ts:2:10 - error TS2305: Module '"child_process"' has no exported member 'Serializable'.

2 import { Serializable } from "child_process";
           ~~~~~~~~~~~~

Updating to node 14 fixed it, seems reasonable enough - 14 is the current LTS version of node.

--

Also sneaks in a package bump to deploy #321

@orta orta requested a review from sandersn as a code owner April 6, 2021 20:47
@orta orta merged commit 69c00c7 into master Apr 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants