Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go mod vendor npipe to this repo #118

Merged
merged 2 commits into from
Jun 16, 2023
Merged

go mod vendor npipe to this repo #118

merged 2 commits into from
Jun 16, 2023

Conversation

shueybubbles
Copy link
Collaborator

Fixes #117
2 parts to the fix

  1. Bring the code over and verify it builds
  2. Implement DialExisting to fix issue where dialing using np doesn't quit immediately when the named pipe doesn't exist.

@codecov-commenter
Copy link

Codecov Report

Merging #118 (7c4207d) into main (70e2d2b) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   74.11%   74.06%   -0.06%     
==========================================
  Files          29       29              
  Lines        5613     5613              
==========================================
- Hits         4160     4157       -3     
- Misses       1206     1208       +2     
- Partials      247      248       +1     

see 1 file with indirect coverage changes

@shueybubbles shueybubbles marked this pull request as ready for review June 12, 2023 20:34
@shueybubbles
Copy link
Collaborator Author

I couldn't get this to work with a vendor folder whose only content was this package, nor did it work with a replace directive in go.mod. I think there's something funky with this old repo that breaks go build with new tools.

Copy link

@apoorvdeshmukh apoorvdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@apoorvdeshmukh
Copy link

Do we need to create another issue to vendor this properly at some later point?

@shueybubbles
Copy link
Collaborator Author

since we keep the license and attribution intact we are ok as-is.
thx

@shueybubbles shueybubbles merged commit c30824f into main Jun 16, 2023
@shueybubbles shueybubbles deleted the shueybubbles/117 branch June 16, 2023 13:29
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Aug 22, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/microsoft/go-mssqldb](https://github.com/microsoft/go-mssqldb) | require | major | `v0.19.0` -> `v1.5.0` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>microsoft/go-mssqldb (github.com/microsoft/go-mssqldb)</summary>

### [`v1.5.0`](https://github.com/microsoft/go-mssqldb/releases/tag/v1.5.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v1.4.0...v1.5.0)

#### What's Changed

-   go mod vendor npipe to this repo by [@&#8203;shueybubbles](https://github.com/shueybubbles) in [microsoft/go-mssqldb#118
-   Enable dependabot for pkg updates by [@&#8203;apoorvdeshmukh](https://github.com/apoorvdeshmukh) in [microsoft/go-mssqldb#119
-   fix: mips and mipsel builds by [@&#8203;powersj](https://github.com/powersj) in [microsoft/go-mssqldb#124
-   Allow for local dns resolution with a custom dialer by [@&#8203;stephaniehingtgen](https://github.com/stephaniehingtgen) in [microsoft/go-mssqldb#121
-   Fixes MarshalText and adds UnmarshalJSON interface for UniqueIdentifier by [@&#8203;Musab-Nazir](https://github.com/Musab-Nazir) in [microsoft/go-mssqldb#126
-   Update README.md by [@&#8203;dlevy-msft](https://github.com/dlevy-msft) in [microsoft/go-mssqldb#132
-   Fix: Handle extended chars in SQL instance names by [@&#8203;shueybubbles](https://github.com/shueybubbles) in [microsoft/go-mssqldb#138

#### New Contributors

-   [@&#8203;powersj](https://github.com/powersj) made their first contribution in [microsoft/go-mssqldb#124
-   [@&#8203;stephaniehingtgen](https://github.com/stephaniehingtgen) made their first contribution in [microsoft/go-mssqldb#121
-   [@&#8203;Musab-Nazir](https://github.com/Musab-Nazir) made their first contribution in [microsoft/go-mssqldb#126
-   [@&#8203;dlevy-msft](https://github.com/dlevy-msft) made their first contribution in [microsoft/go-mssqldb#132

**Full Changelog**: microsoft/go-mssqldb@v1.1.0...v1.5.0

### [`v1.4.0`](https://github.com/microsoft/go-mssqldb/compare/v1.3.0...v1.4.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v1.3.0...v1.4.0)

### [`v1.3.0`](https://github.com/microsoft/go-mssqldb/compare/v1.2.0...v1.3.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v1.2.0...v1.3.0)

### [`v1.2.0`](https://github.com/microsoft/go-mssqldb/compare/v1.1.0...v1.2.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v1.1.0...v1.2.0)

### [`v1.1.0`](https://github.com/microsoft/go-mssqldb/releases/tag/v1.1.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v1.0.0...v1.1.0)

### Version 1.1.0

-   Release date: May 30, 2023

#### What's new in 1.1.0

-   Supports finding the DAC port using the browser service ([#&#8203;110](https://github.com/microsoft/go-mssqldb/issues/110))
-   Updated go package dependencies ([#&#8203;112](https://github.com/microsoft/go-mssqldb/issues/112))

### [`v1.0.0`](https://github.com/microsoft/go-mssqldb/compare/v0.21.0...v1.0.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v0.21.0...v1.0.0)

### [`v0.21.0`](https://github.com/microsoft/go-mssqldb/compare/v0.20.0...v0.21.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v0.20.0...v0.21.0)

### [`v0.20.0`](https://github.com/microsoft/go-mssqldb/compare/v0.19.0...v0.20.0)

[Compare Source](https://github.com/microsoft/go-mssqldb/compare/v0.19.0...v0.20.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41NC4yIiwidXBkYXRlZEluVmVyIjoiMzYuNTQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move npipe implementation into this repo
3 participants