Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate managed identity example to azidentity #199

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

chlowell
Copy link
Member

github.com/Azure/go-autorest/autorest/adal is no longer supported, having been replaced by github.com/Azure/azure-sdk-for-go/sdk/azidentity

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.70%. Comparing base (b3a8513) to head (f98dd81).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   74.70%   74.70%           
=======================================
  Files          32       32           
  Lines        6344     6344           
=======================================
  Hits         4739     4739           
  Misses       1323     1323           
  Partials      282      282           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shueybubbles
Copy link
Collaborator

the azuread package already supports managed identity auth via the connection string if you use azuread.DriverName as the driver name . Might it be better to have the example use that package now?

@chlowell
Copy link
Member Author

Up to you--if there's a better pattern for managed identity that uses a supported library, highlighting it in this example seems like a good idea to me. I'm not familiar with the API here, this PR is just the smallest change required to remove adal from the example.

@shueybubbles shueybubbles merged commit 2395b78 into microsoft:main Jun 10, 2024
7 checks passed
@chlowell chlowell deleted the update-managed-id-example branch June 11, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants