fix interleaving of save/sync operations

microsoft · Sep 9, 2024 · 2eee5f9 · 2eee5f9
1 parent 124290f
commit 2eee5f9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/webapp/src/idbworkspace.ts b/webapp/src/idbworkspace.ts
@@ -285,6 +285,7 @@ async function listAsync(): Promise<pxt.workspace.Header[]> {
 async function getAsync(h: Header): Promise<pxt.workspace.File> {
     const db = await getCurrentDbAsync();
     const res = await db.getAsync<StoredText>(TEXTS_TABLE, h.id);
+    if (!res) return undefined;
     return {
         header: h,
         text: res.files,

diff --git a/webapp/src/workspace.ts b/webapp/src/workspace.ts
@@ -574,7 +574,6 @@ export async function saveAsync(h: Header, text?: ScriptText, fromCloudSync?: bo
             text,
             version: null
         }
-        allScripts.push(e)
     }
 
     const hasUserFileChanges = () => {
@@ -693,6 +692,10 @@ export async function saveAsync(h: Header, text?: ScriptText, fromCloudSync?: bo
             e.version = ver;
         }
 
+        if (newSave) {
+            allScripts.push(e);
+        }
+
         if (isUserChange) {
             h.pubCurrent = false;
             h.cloudCurrent = false;