store block comment position in block data #10164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srietkerk
reviewed
Sep 9, 2024
| if (this.textInputBubble) { | ||
| const coord = this.textInputBubble.getPositionRelativeToAnchor(); | ||
|
|
||
| setBlockDataForField(this.sourceBlock, COMMENT_OFFSET_X_FIELD_NAME, coord.x + ""); |
There was a problem hiding this comment.
Why is the + "" needed for the coordinate?
There was a problem hiding this comment.
it's a number, needs to be a string
There was a problem hiding this comment.
Woah, I didn't know that was a thing, thanks for the info!
srietkerk
approved these changes
Sep 9, 2024
abchatra
pushed a commit
that referenced
this pull request
Sep 12, 2024
* store block comment position in block data * prevent empty string comments from persising saved offset data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes microsoft/pxt-microbit#5889
one of the additions we made in pxt-blockly was the ability for block comments to serialize their position to the XML when saving workspaces. unfortunately, we can't do the same thing with unforked blockly because there are no extension points in the XML serialization of comments. however, blockly does have a data element on blocks that you can stick arbitrary data into and will get saved in the XML (we already use this for persisting data for some of our field editors)
this pr brings back the saving of the comment position by shoving it into the block's data element. note that this will not fix existing projects from before the blockly upgrade, but i really don't think anyone will notice.