Fixed a bug that results in a false positive error when using `__extr…

…a_items__` (PEP 728) with a `TypedDict` imported from `typing_extensions`. This addresses #7784.
microsoft · Apr 27, 2024 · 47c53f9 · 47c53f9
1 parent 2743ba5
commit 47c53f9
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/pyright-internal/src/analyzer/checker.ts b/packages/pyright-internal/src/analyzer/checker.ts
@@ -6751,7 +6751,11 @@ export class Checker extends ParseTreeWalker {
                         }
                     }
 
-                    if (isBaseClassVar !== isClassVar) {
+                    // Allow TypedDict members to have the same name as class variables in the
+                    // base class because TypedDict members are not really instance members.
+                    const ignoreTypedDictOverride = ClassType.isTypedDictClass(childClassType) && !isClassVar;
+
+                    if (isBaseClassVar !== isClassVar && !ignoreTypedDictOverride) {
                         const unformattedMessage = overrideSymbol.isClassVar()
                             ? LocMessage.classVarOverridesInstanceVar()
                             : LocMessage.instanceVarOverridesClassVar();