Fixed recent regression that results in false positive when a inner f…

…unction with an inferred return type is a coroutine (async) and is referenced within the function body in which it's declared. This addresses #8232 and #8229.

packages/pyright-internal/src/analyzer/typeEvaluator.ts

@@ -19878,7 +19878,19 @@ export function createTypeEvaluator(
  // don't bother doing additional work.
  let cacheEntry = readTypeCacheEntry(subnode);
  if (cacheEntry && !cacheEntry.typeResult.isIncomplete) {
- return cacheEntry.typeResult;
+ const typeResult = cacheEntry.typeResult;
+
+ // Handle the special case where a function or class is partially evaluated.
+ // Indicate that these are not complete types.
+ if (isFunction(typeResult.type) && FunctionType.isPartiallyEvaluated(typeResult.type)) {
+ return { ...typeResult, isIncomplete: true };
+ }
+
+ if (isClass(typeResult.type) && ClassType.isPartiallyEvaluated(typeResult.type)) {
+ return { ...typeResult, isIncomplete: true };
+ }
+
+ return typeResult;
  }
 
  callback();

packages/pyright-internal/src/tests/samples/coroutines4.py

@@ -0,0 +1,17 @@
+# This sample tests the case where an inner coroutine with an inferred
+# return type is referenced in a manner that results in recursion.
+
+import asyncio
+
+
+def func1(replace_inner: bool) -> None:
+ inner = lambda: None
+
+ async def wrapper():
+ inner()
+
+ wrapped_fn = wrapper()
+ asyncio.create_task(wrapped_fn)
+
+ if replace_inner:
+ inner = lambda: None

packages/pyright-internal/src/tests/typeEvaluator3.test.ts

@@ -173,6 +173,12 @@ test('Coroutines3', () => {
  TestUtils.validateResults(analysisResults, 0);
 });
 
+test('Coroutines4', () => {
+ const analysisResults = TestUtils.typeAnalyzeSampleFiles(['coroutines4.py']);
+
+ TestUtils.validateResults(analysisResults, 0);
+});
+
 test('Loop1', () => {
  const analysisResults = TestUtils.typeAnalyzeSampleFiles(['loop1.py']);