-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
class inferred as abstract when it isn't. #8245
Labels
addressed in next version
Issue is fixed and will appear in next published version
bug
Something isn't working
Comments
Moreover, it seems this affects only Protocol types. If the base class is changes to |
erictraut
added a commit
that referenced
this issue
Jun 27, 2024
… method implementation that conditionally raises `NotImplementedError`. This addresses #8245.
This is addressed in pyright 1.1.370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
addressed in next version
Issue is fixed and will appear in next published version
bug
Something isn't working
Code sample in pyright playground
It seems pyright infers that
info
is abstract due to the two lines:if
NotImplementedError
is replaced with another type of Exception,info
is no longer inferred as abstract.The text was updated successfully, but these errors were encountered: