Password box bug #4607
Merged
Password box bug #4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #4371 |
kmelmon
added
the
AutoMerge
|
Hello @kmelmon! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
thanks for fixing this! I think this is an issue that the e2eTest is hitting (and failing) so it will be interesting to see if this fixes it |
asklar
approved these changes
Apr 15, 2020
ghost
merged commit 
|
Can we get this fix cherry picked onto 61? |
kmelmon
added a commit
to kmelmon/react-native-windows
that referenced
this pull request
Apr 15, 2020
* bug fix, update test * Change files
kmelmon
added a commit
that referenced
this pull request
Apr 15, 2020
asklar
pushed a commit
to asklar/react-native-windows
that referenced
this pull request
Apr 19, 2020
* bug fix, update test * Change files
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in TextInput. If you don't specify a height and also set secureTextEntry = true, the PasswordBox ends up with a 0 height.
The bug was caused by some missing logic in the code that swaps the TextBox out for a PasswordBox. This code replaces the backing XAML element, but forgot to notify the UIManager which maintains a mapping from ShadowNode => XAML element. Thus, after the swap, bad stuff happens in layout, causing us to push a 0 height into the PasswordBox.
The fix is straightforward - after swapping the control, notify the UIManager so it can update its mapping to the new XAML element.
Also changed our existing Playground test page to not specify a height, this exposes the issue.
Microsoft Reviewers: Open in CodeFlow