Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AccessibilityStates #4625

Merged
2 commits merged into from
Apr 17, 2020
Merged

Conversation

kmelmon
Copy link
Contributor

@kmelmon kmelmon commented Apr 17, 2020

Fixes #4593

Now that we have finished implementing AccessibilityState, and backported to 0.61, this change finally removes the AccessibilityStates API which was deprecated and is no longer part of the RN API.

Microsoft Reviewers: Open in CodeFlow

@kmelmon kmelmon requested a review from a team as a code owner April 17, 2020 00:42
@kmelmon kmelmon changed the title Remove accessibility states Remove AccessibilityStates Apr 17, 2020
@kmelmon kmelmon added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Apr 17, 2020
@ghost
Copy link

ghost commented Apr 17, 2020

Hello @kmelmon!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 51 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit f3d983e into microsoft:master Apr 17, 2020
asklar pushed a commit to asklar/react-native-windows that referenced this pull request Apr 19, 2020
* remove AccessibilityStates

* Change files
@kmelmon kmelmon deleted the removeAccessibilityStates branch April 23, 2020 21:16
NickGerleman added a commit to NickGerleman/react-native-windows that referenced this pull request Apr 24, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove accessibilityStates support from ViewManagers
2 participants