Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing query strings in health probes #2420

Closed
robbieknuth opened this issue Feb 27, 2024 · 0 comments · Fixed by #2421
Closed

Consider allowing query strings in health probes #2420

robbieknuth opened this issue Feb 27, 2024 · 0 comments · Fixed by #2421
Labels
Type: Idea This issue is a high-level idea for discussion.

Comments

@robbieknuth
Copy link
Contributor

What should we add or change to make your life better?

Health probes are currently implemented strictly as paths. It is not possible to probe at at /myhealth?key=value. The resulting probe becomes /myhealth%3Fkey=value

It may or may not be desirable to include query strings in DefaultProbingRequestFactory, however I am opening this for consideration.

Why is this important to you?

Our current health probe includes a query string. It is simple enough to work around this by implementing a IProbingRequestFactory.

@robbieknuth robbieknuth added the Type: Idea This issue is a high-level idea for discussion. label Feb 27, 2024
@MihaZupan MihaZupan added this to the v.Next milestone Mar 5, 2024
@MihaZupan MihaZupan modified the milestones: v.Next, YARP 2.2.0-preview1 May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Idea This issue is a high-level idea for discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants