Allow for using query strings in DefaultProbingRequestFactory. #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
reviewed
Feb 27, 2024
…y is appended to the probing request.
robbieknuth
force-pushed
the
fix-2420
branch
from
63956b9
to
1a5f485
Compare
|
Build issues: New property needs to be initialized in other places. Checking. |
Issues have been addresssed. |
|
Close button is confusing. |
robbieknuth
commented
Feb 27, 2024
MihaZupan
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2420
An attempt at allowing query strings in health probes.
If a query is specified both on the probe address and the probe path, the probe path wins.