Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor functional test environment #1956

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Refactor functional test environment #1956

merged 2 commits into from
Dec 13, 2022

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Dec 8, 2022

I was adding new functional tests for H2WS (#1375) but found the structure of the TestEnvironment difficult to add additional properties to due to the complex constructors. I've re-factored it to use properties instead.

@Tratcher Tratcher added this to the YARP 2.0.0 milestone Dec 8, 2022
@Tratcher Tratcher self-assigned this Dec 8, 2022
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

complex constructors

And they've only grown over time :)

@Tratcher Tratcher merged commit 65af287 into main Dec 13, 2022
@Tratcher Tratcher deleted the tratcher/testenv branch December 13, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants