.Net: New Feature: Support additional properties available in RunCreationOptions via OpenAIAssistantInvocationOptions
#8715
Assignees
Labels
agents
bug
Something isn't working
experimental
Associated with an experimental feature
.NET
Issue or Pull requests regarding .NET code
Comments
crickman
added
bug
github-actions
bot
changed the title
RunCreationOptions via OpenAIAssistantInvocationOptionsRunCreationOptions via OpenAIAssistantInvocationOptions
|
@joeyj - Thank you for this call-out. This wasn't intentional, just an oversite and can certainly be exposed. |
4 tasks
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 17, 2024
…on (#8852) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Respond to two customer identified issues: 1. Add support for `AdditionalInstructions` for creating an assistant as well as invocation override. Fixes #8715 2. Fix issue with duplicated tool-call result when using `ChatCompletionAgent` streaming Fixes #8825 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. `AdditionalInstructions` option wasn't included in the V2 migration as oversight. This is a pure addition. 2. Unit-tests added for new `AdditionalInstructions` option. 4. Duplication of the terminated function result addressed within `ChatCompletionAgent` 5. Streaming cases added to existing sample demonstrating use of `IAutoFunctionInvocationFilter` : `Concepts/Agents/ChatCompletion_FunctionTermination` ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We would like the ability to specify
AdditionalInstructionswhen invoking anOpenAIAssistantAgent; however, this is not defined onOpenAIAssistantInvocationOptionsbut this property is defined onRunCreationOptions.The text was updated successfully, but these errors were encountered: