Java: ADR to define the folder structure to be used for the Java port #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnoliver
previously approved these changes
Jun 19, 2023
karianna
approved these changes
Jun 19, 2023
markwallace-microsoft
force-pushed
the
users/markwallace/adr-java-folder-structure
branch
from
da2d84b
to
4955919
Compare
shawncal
reviewed
Jun 19, 2023
brunoborges
reviewed
Jun 19, 2023
shawncal
force-pushed
the
users/markwallace/adr-java-folder-structure
branch
from
0e8f589
to
613413c
Compare
markwallace-microsoft
force-pushed
the
users/markwallace/adr-java-folder-structure
branch
from
613413c
to
63a85a6
Compare
shawncal
force-pushed
the
users/markwallace/adr-java-folder-structure
branch
from
2f7bfd3
to
0721765
Compare
|
@markwallace-microsoft just converted to draft while you're waiting for answers. Please flip back to active and ping me when ready. |
shawncal
force-pushed
the
users/markwallace/adr-java-folder-structure
branch
from
0721765
to
7e0dd24
Compare
shawncal
changed the title
shawncal
added
docs and tests
johnoliver
approved these changes
Jul 11, 2023
markwallace-microsoft
deleted the
users/markwallace/adr-java-folder-structure
branch
piotrek-appstream
pushed a commit
to Appstream-Studio/semantic-kernel
that referenced
this pull request
Jul 19, 2023
…microsoft#1547) ### Motivation and Context Please help reviewers and future users, providing the following information: 1. Why is this change required? The folder structure used in the Java port has diverged from that used in .Net. Some of the changes make sense i.e., are idiomatic Java and others we should review. ### Description ADR to define the folder structure to be used for the Java port. This includes a comparison of the current .Net and Java folder structures and proposal for the Java folder structure we should move towards. ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
piotrek-appstream
added a commit
to Appstream-Studio/semantic-kernel
that referenced
this pull request
Jul 19, 2023
* Python: Bump python SK package version (#1927) * .Net: Bump xunit.runner.visualstudio from 2.4.5 to 2.5.0 in /dotnet (#1935) Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) from 2.4.5 to 2.5.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/5ebf84cd7537a3810772a1af751ce32d9d3930dc"><code>5ebf84c</code></a> v2.5.0</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/fd327b6da7a4fa9e86889cc529def80a281e03c5"><code>fd327b6</code></a> Ensure both failed tests and errors cancel for stopOnFail</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/4e86b435fee8df445ec78b858777faba34625611"><code>4e86b43</code></a> Latest dependencies</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/c29a7604e9c7bd6166006e55e4d93abc811bf404"><code>c29a760</code></a> <a href="https://redirect.github.com/xunit/visualstudio.xunit/issues/110">#110</a>: Visual Studio test explorer cannot filter skipped tests by message</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/5e961608fe30e9490d6c7a1a0e3a751c923ae4dd"><code>5e96160</code></a> <a href="https://redirect.github.com/xunit/visualstudio.xunit/issues/189">#189</a>: Support 'stopOnFail' configuration file setting</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/671542c4db6242900d44fe367da102d8b031cc6a"><code>671542c</code></a> <a href="https://redirect.github.com/xunit/visualstudio.xunit/issues/331">#331</a>: DisableAppDomain switch is not fully respected for Discovery</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/1aa409de388c9dabd6766b28abbdb78f4499b461"><code>1aa409d</code></a> Add net472 build of test.harness which turns off app domains (for performance...</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/ff89c51f426085d115fbf20b3527182fbd56b7f1"><code>ff89c51</code></a> Latest dependencies</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/f9d61b59b8fe43800f474c45ec37fc3efa2d60ab"><code>f9d61b5</code></a> <a href="https://redirect.github.com/xunit/visualstudio.xunit/issues/317">#317</a>: Slow performance on discovery / running due to discovering TestReporters</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/01ec27d6e9603182ea9c7aa23d03758e3c996947"><code>01ec27d</code></a> Latest dependencies</li> <li>Additional commits viewable in <a href="https://github.com/xunit/visualstudio.xunit/compare/v2.4.5...2.5.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * .Net: Bump xunit.analyzers from 1.1.0 to 1.2.0 in /dotnet (#1934) Bumps [xunit.analyzers](https://github.com/xunit/xunit.analyzers) from 1.1.0 to 1.2.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/xunit/xunit.analyzers/commit/528163222110e61806d94bcd61bc2f54063e1bfa"><code>5281632</code></a> v1.2.0</li> <li><a href="https://github.com/xunit/xunit.analyzers/commit/10548c279124d4a50a616814748f08d2038b2f6d"><code>10548c2</code></a> Latest dependencies</li> <li><a href="https://github.com/xunit/xunit.analyzers/commit/09df47576c26d002fea388c4ccb01c0bb115457e"><code>09df475</code></a> <a href="https://redirect.github.com/xunit/xunit/issues/2277">xunit/xunit#2277</a>: Analyzers should disallow Xunit attributes on local functions</li> <li><a href="https://github.com/xunit/xunit.analyzers/commit/cef31f9192a90cd8c09785f84ad7bcad627cac99"><code>cef31f9</code></a> Roll back to Roslyn 4.0.1, to match up against Visual Studio 2022 RTM</li> <li><a href="https://github.com/xunit/xunit.analyzers/commit/ed82d71f744d69fc9cabda2fa0bc75de4fe8f9f4"><code>ed82d71</code></a> Move descriptors to XunitDiagnosticAnalyzer constructor</li> <li><a href="https://github.com/xunit/xunit.analyzers/commit/b35efcf1c2e084d4ad743297c15ed53c81c72511"><code>b35efcf</code></a> <a href="https://redirect.github.com/xunit/xunit/issues/2736">xunit/xunit#2736</a>: xUnit2013 doesn't trigger when using .Count on direct colle...</li> <li><a href="https://github.com/xunit/xunit.analyzers/commit/c43b57a96e6e8c980e07fc74ee3e43e0232f2c52"><code>c43b57a</code></a> <a href="https://redirect.github.com/xunit/xunit/issues/2734">xunit/xunit#2734</a>: xUnit1010 triggered on compatible data type</li> <li><a href="https://github.com/xunit/xunit.analyzers/commit/39cf02772228887ee6073085d793b998ff3b91a9"><code>39cf027</code></a> Move constant-based symbol lookup to TypeSymbolFactory</li> <li><a href="https://github.com/xunit/xunit.analyzers/commit/d6a51c60981d7773ad3e2b90f00294158da8f1c4"><code>d6a51c6</code></a> <a href="https://redirect.github.com/xunit/xunit/issues/2735">xunit/xunit#2735</a>: xUnit1019 should be updated to support ITheoryDataRow in v3</li> <li><a href="https://github.com/xunit/xunit.analyzers/commit/8223e10ee6de41e4b2e5f346dabcc8b3a772831a"><code>8223e10</code></a> Formatting</li> <li>Additional commits viewable in <a href="https://github.com/xunit/xunit.analyzers/compare/1.1.0...1.2.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Python: Bump weaviate-client from 3.21.0 to 3.22.1 in /python (#1938) Bumps [weaviate-client](https://github.com/weaviate/weaviate-python-client) from 3.21.0 to 3.22.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/weaviate/weaviate-python-client/releases">weaviate-client's releases</a>.</em></p> <blockquote> <h2>v3.22.1</h2> <h2>What's Changed</h2> <ul> <li>Don't block clients in air-gaped environments by <a href="https://github.com/dirkkul"><code>@dirkkul</code></a> in <a href="https://redirect.github.com/weaviate/weaviate-python-client/pull/373">weaviate/weaviate-python-client#373</a></li> <li>Add tenant as an optional param to batch.delete_objects by <a href="https://github.com/ciprianaradulescu"><code>@ciprianaradulescu</code></a> in <a href="https://redirect.github.com/weaviate/weaviate-python-client/pull/375">weaviate/weaviate-python-client#375</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/ciprianaradulescu"><code>@ciprianaradulescu</code></a> made their first contribution in <a href="https://redirect.github.com/weaviate/weaviate-python-client/pull/375">weaviate/weaviate-python-client#375</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/weaviate/weaviate-python-client/compare/v3.22.0...v3.22.1">https://github.com/weaviate/weaviate-python-client/compare/v3.22.0...v3.22.1</a></p> <h2>v3.22.0</h2> <h2>What's Changed</h2> <ul> <li>Fix erroneous docstring in Schema.exists by <a href="https://github.com/apetresc"><code>@apetresc</code></a> in <a href="https://redirect.github.com/weaviate/weaviate-python-client/pull/364">weaviate/weaviate-python-client#364</a></li> <li>Add support for tenants endpoints by <a href="https://github.com/antas-marcin"><code>@antas-marcin</code></a> in <a href="https://redirect.github.com/weaviate/weaviate-python-client/pull/345">weaviate/weaviate-python-client#345</a></li> <li>Add class parameter to nodes api by <a href="https://github.com/dirkkul"><code>@dirkkul</code></a> in <a href="https://redirect.github.com/weaviate/weaviate-python-client/pull/365">weaviate/weaviate-python-client#365</a></li> <li>Add support for autocut by <a href="https://github.com/dirkkul"><code>@dirkkul</code></a> in <a href="https://redirect.github.com/weaviate/weaviate-python-client/pull/366">weaviate/weaviate-python-client#366</a></li> <li>Add hybrid fusion type by <a href="https://github.com/dirkkul"><code>@dirkkul</code></a> in <a href="https://redirect.github.com/weaviate/weaviate-python-client/pull/367">weaviate/weaviate-python-client#367</a></li> <li>Warn when weaviate client outdated by <a href="https://github.com/iangregson"><code>@iangregson</code></a> in <a href="https://redirect.github.com/weaviate/weaviate-python-client/pull/343">weaviate/weaviate-python-client#343</a></li> <li>Feature: add .with_limit() method to AggregateBuilder by <a href="https://github.com/tsmith023"><code>@tsmith023</code></a> in <a href="https://redirect.github.com/weaviate/weaviate-python-client/pull/369">weaviate/weaviate-python-client#369</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/apetresc"><code>@apetresc</code></a> made their first contribution in <a href="https://redirect.github.com/weaviate/weaviate-python-client/pull/364">weaviate/weaviate-python-client#364</a></li> <li><a href="https://github.com/iangregson"><code>@iangregson</code></a> made their first contribution in <a href="https://redirect.github.com/weaviate/weaviate-python-client/pull/343">weaviate/weaviate-python-client#343</a></li> <li><a href="https://github.com/tsmith023"><code>@tsmith023</code></a> made their first contribution in <a href="https://redirect.github.com/weaviate/weaviate-python-client/pull/369">weaviate/weaviate-python-client#369</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/weaviate/weaviate-python-client/compare/v3.21.0...v3.22.0">https://github.com/weaviate/weaviate-python-client/compare/v3.21.0...v3.22.0</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/weaviate/weaviate-python-client/blob/main/docs/changelog.rst">weaviate-client's changelog</a>.</em></p> <blockquote> <h2>Version 3.22.1</h2> <p>This patch version includes:</p> <ul> <li>Fix "is client outdated"-check in air-gaped environments</li> <li>Add <code>tenant</code> to batch delete</li> </ul> <h2>Version 3.22.0</h2> <p>This minor version includes:</p> <ul> <li>Multi-tenancy</li> <li>Aggregate with limit</li> <li>Autocut</li> <li>Fusion type for hybrid search</li> <li>Client emits a warning when it is outdated (three minor version behind last release on pypi)</li> <li>Increase default embedded version to 1.19.12</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/weaviate/weaviate-python-client/commit/32e6b2a42c307f84a2ea4d9ebb201f5319e32e0b"><code>32e6b2a</code></a> Merge pull request <a href="https://redirect.github.com/weaviate/weaviate-python-client/issues/376">#376</a> from weaviate/release/3.22.1</li> <li><a href="https://github.com/weaviate/weaviate-python-client/commit/7bf4910c8b9a16058411d36824ee2b5be77944e4"><code>7bf4910</code></a> 3.22.1</li> <li><a href="https://github.com/weaviate/weaviate-python-client/commit/b733212c88d649c22e68fb5052165f8d63253ccb"><code>b733212</code></a> Merge pull request <a href="https://redirect.github.com/weaviate/weaviate-python-client/issues/375">#375</a> from ciprianaradulescu/main</li> <li><a href="https://github.com/weaviate/weaviate-python-client/commit/8b1c1386140947d5d0e61f4d658484981ac4edb9"><code>8b1c138</code></a> reformat according to black</li> <li><a href="https://github.com/weaviate/weaviate-python-client/commit/eb3bf1668cb86a96b00fe23c1894d9bbf3ed975b"><code>eb3bf16</code></a> extend integration tests to cover batch delete with tenant</li> <li><a href="https://github.com/weaviate/weaviate-python-client/commit/d2c4c2aff011b71754495d0c5e51d79e6b1a962e"><code>d2c4c2a</code></a> add tenant as an optional param to batch.delete_objects</li> <li><a href="https://github.com/weaviate/weaviate-python-client/commit/0e763d4b36805734ee4df91e1cf5146ffcc20450"><code>0e763d4</code></a> Merge pull request <a href="https://redirect.github.com/weaviate/weaviate-python-client/issues/373">#373</a> from weaviate/timeout_pypi</li> <li><a href="https://github.com/weaviate/weaviate-python-client/commit/30880ed60114f91c166a6f028307b3c416534637"><code>30880ed</code></a> Skip client up-to-date check in air-gaped environments</li> <li><a href="https://github.com/weaviate/weaviate-python-client/commit/fb5301a56e66963ccf031c47bfe9dd7d859fd320"><code>fb5301a</code></a> Add timeout for pypi connection</li> <li><a href="https://github.com/weaviate/weaviate-python-client/commit/af2c9c13310b4b5aea157c5461418359b0e13ad2"><code>af2c9c1</code></a> Merge pull request <a href="https://redirect.github.com/weaviate/weaviate-python-client/issues/371">#371</a> from weaviate/release/v3.22.0</li> <li>Additional commits viewable in <a href="https://github.com/weaviate/weaviate-python-client/compare/v3.21.0...v3.22.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * .Net: Bump Microsoft.Azure.Functions.Worker from 1.16.0 to 1.17.0 in /dotnet (#1936) Bumps [Microsoft.Azure.Functions.Worker](https://github.com/Azure/azure-functions-dotnet-worker) from 1.16.0 to 1.17.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/Azure/azure-functions-dotnet-worker/releases">Microsoft.Azure.Functions.Worker's releases</a>.</em></p> <blockquote> <h2>Microsoft.Azure.Functions.Worker 1.17.0</h2> <h2>What's Changed</h2> <h3>Microsoft.Azure.Functions.Worker (metapackage) 1.17.0</h3> <ul> <li>Nothing</li> </ul> <h3>Microsoft.Azure.Functions.Worker.Core 1.13.0</h3> <ul> <li>Nothing</li> </ul> <h3>Microsoft.Azure.Functions.Worker.Grpc 1.12.0</h3> <ul> <li>bumping grpc packages by <a href="https://github.com/brettsam"><code>@brettsam</code></a> in <a href="https://redirect.github.com/Azure/azure-functions-dotnet-worker/pull/1719">Azure/azure-functions-dotnet-worker#1719</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/Azure/azure-functions-dotnet-worker/compare/1.16.0...1.17.0">https://github.com/Azure/azure-functions-dotnet-worker/compare/1.16.0...1.17.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/Azure/azure-functions-dotnet-worker/commit/68cb6ca7e3c93753d76d31eaf982a7584672b28a"><code>68cb6ca</code></a> bumping grpc packages (<a href="https://redirect.github.com/Azure/azure-functions-dotnet-worker/issues/1719">#1719</a>)</li> <li><a href="https://github.com/Azure/azure-functions-dotnet-worker/commit/f3b49344ea3ce15a7aa7ac54db5b456dd80b7a6d"><code>f3b4934</code></a> Reset release notes for Worker and SDK packages</li> <li><a href="https://github.com/Azure/azure-functions-dotnet-worker/commit/6910409b8b3090215c4807f392820aa8c4396258"><code>6910409</code></a> [Source Gen] Add retry options diagnostic descriptors (<a href="https://redirect.github.com/Azure/azure-functions-dotnet-worker/issues/1683">#1683</a>)</li> <li>See full diff in <a href="https://github.com/Azure/azure-functions-dotnet-worker/compare/1.16.0...1.17.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Python: Bump chromadb from 0.3.26 to 0.3.27 in /python (#1939) Bumps [chromadb](https://github.com/chroma-core/chroma) from 0.3.26 to 0.3.27. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/chroma-core/chroma/releases">chromadb's releases</a>.</em></p> <blockquote> <h2>0.3.27</h2> <p>Version: <code>0.3.27</code> Git ref: <code>refs/tags/0.3.27</code> Build Date: <code>2023-07-10T19:54</code> PIP Package: <code>chroma-0.3.27.tar.gz</code> Docker Image: <code>ghcr.io/chroma-core/chroma:0.3.27</code></p> <h2>What's Changed</h2> <ul> <li>[easy] remove duplicate pypika from requirements.txt by <a href="https://github.com/abizerll"><code>@abizerll</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/693">chroma-core/chroma#693</a></li> <li>fix wrong return type by <a href="https://github.com/tegardp"><code>@tegardp</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/613">chroma-core/chroma#613</a></li> <li>Fail validation for bools in metadata by <a href="https://github.com/atroyn"><code>@atroyn</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/672">chroma-core/chroma#672</a></li> <li>Add embedding support for Transformers.js by <a href="https://github.com/xenova"><code>@xenova</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/664">chroma-core/chroma#664</a></li> <li>Return ns since epoch on /heartbeat by <a href="https://github.com/kristofferostlund"><code>@kristofferostlund</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/712">chroma-core/chroma#712</a></li> <li>fix JS Where type, closes <a href="https://redirect.github.com/chroma-core/chroma/issues/718">#718</a> by <a href="https://github.com/jeffchuber"><code>@jeffchuber</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/722">chroma-core/chroma#722</a></li> <li>fix(gcp): fixed terraform definitions for gcp example by <a href="https://github.com/Rezrazi"><code>@Rezrazi</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/632">chroma-core/chroma#632</a></li> <li>Fixes some typos in the docstring for Python collection.add(...) call by <a href="https://github.com/worldveil"><code>@worldveil</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/673">chroma-core/chroma#673</a></li> <li><a href="https://redirect.github.com/chroma-core/chroma/issues/642">#642</a> - Fix for hnswlib docker build issues by <a href="https://github.com/perryrobinson"><code>@perryrobinson</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/690">chroma-core/chroma#690</a></li> <li>update client usage in example by <a href="https://github.com/suhasdeshpande"><code>@suhasdeshpande</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/724">chroma-core/chroma#724</a></li> <li>fix cohere api key by <a href="https://github.com/tonisives"><code>@tonisives</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/726">chroma-core/chroma#726</a></li> <li>Enable custom JS Client headers during request to Chroma Instance by <a href="https://github.com/timothycarambat"><code>@timothycarambat</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/728">chroma-core/chroma#728</a></li> <li>Normalized embeddings by <a href="https://github.com/albertovilla"><code>@albertovilla</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/737">chroma-core/chroma#737</a></li> <li>Examples folder refactor by <a href="https://github.com/jeffchuber"><code>@jeffchuber</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/736">chroma-core/chroma#736</a></li> <li>fix port str by <a href="https://github.com/jeffchuber"><code>@jeffchuber</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/758">chroma-core/chroma#758</a></li> <li>bump JS to fix cohere embedding function by <a href="https://github.com/jeffchuber"><code>@jeffchuber</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/742">chroma-core/chroma#742</a></li> <li>cohere by <a href="https://github.com/jeffchuber"><code>@jeffchuber</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/743">chroma-core/chroma#743</a></li> <li>Fix types from numpy by <a href="https://github.com/jeffchuber"><code>@jeffchuber</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/735">chroma-core/chroma#735</a></li> <li>API implementation for segment-based architecture by <a href="https://github.com/levand"><code>@levand</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/662">chroma-core/chroma#662</a></li> <li>[Experimental] Distance distribution relevance by <a href="https://github.com/atroyn"><code>@atroyn</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/762">chroma-core/chroma#762</a></li> <li>JS Improvements by <a href="https://github.com/jeffchuber"><code>@jeffchuber</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/649">chroma-core/chroma#649</a></li> <li>Hardpin pyproject.toml to fix <a href="https://redirect.github.com/chroma-core/chroma/issues/774">#774</a> by <a href="https://github.com/HammadB"><code>@HammadB</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/783">chroma-core/chroma#783</a></li> <li>Release 0.3.27 by <a href="https://github.com/HammadB"><code>@HammadB</code></a> in <a href="https://redirect.github.com/chroma-core/chroma/pull/784">chroma-core/chroma#784</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/abizerll"><code>@abizerll</code></a> made their first contribution in <a href="https://redirect.github.com/chroma-core/chroma/pull/693">chroma-core/chroma#693</a></li> <li><a href="https://github.com/tegardp"><code>@tegardp</code></a> made their first contribution in <a href="https://redirect.github.com/chroma-core/chroma/pull/613">chroma-core/chroma#613</a></li> <li><a href="https://github.com/xenova"><code>@xenova</code></a> made their first contribution in <a href="https://redirect.github.com/chroma-core/chroma/pull/664">chroma-core/chroma#664</a></li> <li><a href="https://github.com/kristofferostlund"><code>@kristofferostlund</code></a> made their first contribution in <a href="https://redirect.github.com/chroma-core/chroma/pull/712">chroma-core/chroma#712</a></li> <li><a href="https://github.com/Rezrazi"><code>@Rezrazi</code></a> made their first contribution in <a href="https://redirect.github.com/chroma-core/chroma/pull/632">chroma-core/chroma#632</a></li> <li><a href="https://github.com/worldveil"><code>@worldveil</code></a> made their first contribution in <a href="https://redirect.github.com/chroma-core/chroma/pull/673">chroma-core/chroma#673</a></li> <li><a href="https://github.com/suhasdeshpande"><code>@suhasdeshpande</code></a> made their first contribution in <a href="https://redirect.github.com/chroma-core/chroma/pull/724">chroma-core/chroma#724</a></li> <li><a href="https://github.com/tonisives"><code>@tonisives</code></a> made their first contribution in <a href="https://redirect.github.com/chroma-core/chroma/pull/726">chroma-core/chroma#726</a></li> <li><a href="https://github.com/timothycarambat"><code>@timothycarambat</code></a> made their first contribution in <a href="https://redirect.github.com/chroma-core/chroma/pull/728">chroma-core/chroma#728</a></li> <li><a href="https://github.com/albertovilla"><code>@albertovilla</code></a> made their first contribution in <a href="https://redirect.github.com/chroma-core/chroma/pull/737">chroma-core/chroma#737</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/chroma-core/chroma/compare/0.3.26...0.3.27">https://github.com/chroma-core/chroma/compare/0.3.26...0.3.27</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/chroma-core/chroma/commit/1c30c7b2a0c325179c3907a784def43e20c7b74c"><code>1c30c7b</code></a> Release 0.3.27 (<a href="https://redirect.github.com/chroma-core/chroma/issues/784">#784</a>)</li> <li><a href="https://github.com/chroma-core/chroma/commit/222294c461d4da5d2f4435d092cf8fa8de22a4a8"><code>222294c</code></a> Hardpin pyproject.toml to fix <a href="https://redirect.github.com/chroma-core/chroma/issues/774">#774</a> (<a href="https://redirect.github.com/chroma-core/chroma/issues/783">#783</a>)</li> <li><a href="https://github.com/chroma-core/chroma/commit/aae36f57b174fbd5e6e3b3decaade1c24b146517"><code>aae36f5</code></a> JS Improvements (<a href="https://redirect.github.com/chroma-core/chroma/issues/649">#649</a>)</li> <li><a href="https://github.com/chroma-core/chroma/commit/d5f8ffbfcfabd7dff97e09bb69c51c619e39810b"><code>d5f8ffb</code></a> [Experimental] Distance distribution relevance (<a href="https://redirect.github.com/chroma-core/chroma/issues/762">#762</a>)</li> <li><a href="https://github.com/chroma-core/chroma/commit/13bf3e070f6ca18eb8a16f4aa895abac0abe66a0"><code>13bf3e0</code></a> API implementation for segment-based architecture (<a href="https://redirect.github.com/chroma-core/chroma/issues/662">#662</a>)</li> <li><a href="https://github.com/chroma-core/chroma/commit/d6df0e4cdd7b2d91e9fa7bbf16e934b0ba830410"><code>d6df0e4</code></a> Fix types from numpy (<a href="https://redirect.github.com/chroma-core/chroma/issues/735">#735</a>)</li> <li><a href="https://github.com/chroma-core/chroma/commit/055d6cf6b25a818204f2be3a54d9eac54923f545"><code>055d6cf</code></a> cohere (<a href="https://redirect.github.com/chroma-core/chroma/issues/743">#743</a>)</li> <li><a href="https://github.com/chroma-core/chroma/commit/11d80a4b63594632424e7c21cd69774b1564c0b6"><code>11d80a4</code></a> bump JS to fix cohere embedding function (<a href="https://redirect.github.com/chroma-core/chroma/issues/742">#742</a>)</li> <li><a href="https://github.com/chroma-core/chroma/commit/f92ed424e006f4df36006a0f48faee786acdd4e2"><code>f92ed42</code></a> fix port str (<a href="https://redirect.github.com/chroma-core/chroma/issues/758">#758</a>)</li> <li><a href="https://github.com/chroma-core/chroma/commit/666bfc40f3e380d91df2fb0d99d6124c9e53d36e"><code>666bfc4</code></a> Examples folder refactor (<a href="https://redirect.github.com/chroma-core/chroma/issues/736">#736</a>)</li> <li>Additional commits viewable in <a href="https://github.com/chroma-core/chroma/compare/0.3.26...0.3.27">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Make bug report more inclusive of programming languages other than dotnet (#1924) ### Motivation and Context Small PR that makes it more explicit which programming language the bug is associated with ### Description Renames the desktop section to platform and replaces the explicit NuGet package suggestion with "Source": <img width="490" alt="image" src="https://github.com/microsoft/semantic-kernel/assets/146438/a760fcf6-8c2b-4bcb-a2a1-8ab7d3bf98e2"> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone :smile: Co-authored-by: Craig Presti <craig.presti@microsoft.com> * Bump semver from 6.3.0 to 6.3.1 in /samples/apps/chat-summary-webapp-react (#1943) Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 6.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/npm/node-semver/releases">semver's releases</a>.</em></p> <blockquote> <h2>v6.3.1</h2> <h2><a href="https://github.com/npm/node-semver/compare/v6.3.0...v6.3.1">6.3.1</a> (2023-07-10)</h2> <h3>Bug Fixes</h3> <ul> <li><a href="https://github.com/npm/node-semver/commit/928e56d21150da0413a3333a3148b20e741a920c"><code>928e56d</code></a> <a href="https://redirect.github.com/npm/node-semver/pull/591">#591</a> better handling of whitespace (<a href="https://redirect.github.com/npm/node-semver/issues/591">#591</a>) (<a href="https://github.com/lukekarrys"><code>@lukekarrys</code></a>, <a href="https://github.com/joaomoreno"><code>@joaomoreno</code></a>, <a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/npm/node-semver/blob/v6.3.1/CHANGELOG.md">semver's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/npm/node-semver/compare/v6.3.0...v6.3.1">6.3.1</a> (2023-07-10)</h2> <h3>Bug Fixes</h3> <ul> <li><a href="https://github.com/npm/node-semver/commit/928e56d21150da0413a3333a3148b20e741a920c"><code>928e56d</code></a> <a href="https://redirect.github.com/npm/node-semver/pull/591">#591</a> better handling of whitespace (<a href="https://redirect.github.com/npm/node-semver/issues/591">#591</a>) (<a href="https://github.com/lukekarrys"><code>@lukekarrys</code></a>, <a href="https://github.com/joaomoreno"><code>@joaomoreno</code></a>, <a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> <h2>6.2.0</h2> <ul> <li>Coerce numbers to strings when passed to semver.coerce()</li> <li>Add <code>rtl</code> option to coerce from right to left</li> </ul> <h2>6.1.3</h2> <ul> <li>Handle X-ranges properly in includePrerelease mode</li> </ul> <h2>6.1.2</h2> <ul> <li>Do not throw when testing invalid version strings</li> </ul> <h2>6.1.1</h2> <ul> <li>Add options support for semver.coerce()</li> <li>Handle undefined version passed to Range.test</li> </ul> <h2>6.1.0</h2> <ul> <li>Add semver.compareBuild function</li> <li>Support <code>*</code> in semver.intersects</li> </ul> <h2>6.0</h2> <ul> <li> <p>Fix <code>intersects</code> logic.</p> <p>This is technically a bug fix, but since it is also a change to behavior that may require users updating their code, it is marked as a major version increment.</p> </li> </ul> <h2>5.7</h2> <ul> <li>Add <code>minVersion</code> method</li> </ul> <h2>5.6</h2> <ul> <li>Move boolean <code>loose</code> param to an options object, with backwards-compatibility protection.</li> <li>Add ability to opt out of special prerelease version handling with the <code>includePrerelease</code> option flag.</li> </ul> <h2>5.5</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/npm/node-semver/commit/44d27bc007e4827e9b797d6145f1076c127005f2"><code>44d27bc</code></a> chore: release 6.3.1</li> <li><a href="https://github.com/npm/node-semver/commit/928e56d21150da0413a3333a3148b20e741a920c"><code>928e56d</code></a> fix: better handling of whitespace (<a href="https://redirect.github.com/npm/node-semver/issues/591">#591</a>)</li> <li><a href="https://github.com/npm/node-semver/commit/39f632690ea5b1b0d64fa913aa0f96f42b9bde32"><code>39f6326</code></a> chore: <code>@npmcli/template-oss</code><a href="https://github.com/4"><code>@4</code></a>.16.0</li> <li>See full diff in <a href="https://github.com/npm/node-semver/compare/v6.3.0...v6.3.1">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~lukekarrys">lukekarrys</a>, a new releaser for semver since your current version.</p> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/microsoft/semantic-kernel/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump semver from 6.3.0 to 6.3.1 in /samples/apps/github-qna-webapp-react (#1946) Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 6.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/npm/node-semver/releases">semver's releases</a>.</em></p> <blockquote> <h2>v6.3.1</h2> <h2><a href="https://github.com/npm/node-semver/compare/v6.3.0...v6.3.1">6.3.1</a> (2023-07-10)</h2> <h3>Bug Fixes</h3> <ul> <li><a href="https://github.com/npm/node-semver/commit/928e56d21150da0413a3333a3148b20e741a920c"><code>928e56d</code></a> <a href="https://redirect.github.com/npm/node-semver/pull/591">#591</a> better handling of whitespace (<a href="https://redirect.github.com/npm/node-semver/issues/591">#591</a>) (<a href="https://github.com/lukekarrys"><code>@lukekarrys</code></a>, <a href="https://github.com/joaomoreno"><code>@joaomoreno</code></a>, <a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/npm/node-semver/blob/v6.3.1/CHANGELOG.md">semver's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/npm/node-semver/compare/v6.3.0...v6.3.1">6.3.1</a> (2023-07-10)</h2> <h3>Bug Fixes</h3> <ul> <li><a href="https://github.com/npm/node-semver/commit/928e56d21150da0413a3333a3148b20e741a920c"><code>928e56d</code></a> <a href="https://redirect.github.com/npm/node-semver/pull/591">#591</a> better handling of whitespace (<a href="https://redirect.github.com/npm/node-semver/issues/591">#591</a>) (<a href="https://github.com/lukekarrys"><code>@lukekarrys</code></a>, <a href="https://github.com/joaomoreno"><code>@joaomoreno</code></a>, <a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> <h2>6.2.0</h2> <ul> <li>Coerce numbers to strings when passed to semver.coerce()</li> <li>Add <code>rtl</code> option to coerce from right to left</li> </ul> <h2>6.1.3</h2> <ul> <li>Handle X-ranges properly in includePrerelease mode</li> </ul> <h2>6.1.2</h2> <ul> <li>Do not throw when testing invalid version strings</li> </ul> <h2>6.1.1</h2> <ul> <li>Add options support for semver.coerce()</li> <li>Handle undefined version passed to Range.test</li> </ul> <h2>6.1.0</h2> <ul> <li>Add semver.compareBuild function</li> <li>Support <code>*</code> in semver.intersects</li> </ul> <h2>6.0</h2> <ul> <li> <p>Fix <code>intersects</code> logic.</p> <p>This is technically a bug fix, but since it is also a change to behavior that may require users updating their code, it is marked as a major version increment.</p> </li> </ul> <h2>5.7</h2> <ul> <li>Add <code>minVersion</code> method</li> </ul> <h2>5.6</h2> <ul> <li>Move boolean <code>loose</code> param to an options object, with backwards-compatibility protection.</li> <li>Add ability to opt out of special prerelease version handling with the <code>includePrerelease</code> option flag.</li> </ul> <h2>5.5</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/npm/node-semver/commit/44d27bc007e4827e9b797d6145f1076c127005f2"><code>44d27bc</code></a> chore: release 6.3.1</li> <li><a href="https://github.com/npm/node-semver/commit/928e56d21150da0413a3333a3148b20e741a920c"><code>928e56d</code></a> fix: better handling of whitespace (<a href="https://redirect.github.com/npm/node-semver/issues/591">#591</a>)</li> <li><a href="https://github.com/npm/node-semver/commit/39f632690ea5b1b0d64fa913aa0f96f42b9bde32"><code>39f6326</code></a> chore: <code>@npmcli/template-oss</code><a href="https://github.com/4"><code>@4</code></a>.16.0</li> <li>See full diff in <a href="https://github.com/npm/node-semver/compare/v6.3.0...v6.3.1">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~lukekarrys">lukekarrys</a>, a new releaser for semver since your current version.</p> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/microsoft/semantic-kernel/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump semver from 6.3.0 to 6.3.1 in /samples/apps/book-creator-webapp-react (#1945) Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 6.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/npm/node-semver/releases">semver's releases</a>.</em></p> <blockquote> <h2>v6.3.1</h2> <h2><a href="https://github.com/npm/node-semver/compare/v6.3.0...v6.3.1">6.3.1</a> (2023-07-10)</h2> <h3>Bug Fixes</h3> <ul> <li><a href="https://github.com/npm/node-semver/commit/928e56d21150da0413a3333a3148b20e741a920c"><code>928e56d</code></a> <a href="https://redirect.github.com/npm/node-semver/pull/591">#591</a> better handling of whitespace (<a href="https://redirect.github.com/npm/node-semver/issues/591">#591</a>) (<a href="https://github.com/lukekarrys"><code>@lukekarrys</code></a>, <a href="https://github.com/joaomoreno"><code>@joaomoreno</code></a>, <a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/npm/node-semver/blob/v6.3.1/CHANGELOG.md">semver's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/npm/node-semver/compare/v6.3.0...v6.3.1">6.3.1</a> (2023-07-10)</h2> <h3>Bug Fixes</h3> <ul> <li><a href="https://github.com/npm/node-semver/commit/928e56d21150da0413a3333a3148b20e741a920c"><code>928e56d</code></a> <a href="https://redirect.github.com/npm/node-semver/pull/591">#591</a> better handling of whitespace (<a href="https://redirect.github.com/npm/node-semver/issues/591">#591</a>) (<a href="https://github.com/lukekarrys"><code>@lukekarrys</code></a>, <a href="https://github.com/joaomoreno"><code>@joaomoreno</code></a>, <a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> <h2>6.2.0</h2> <ul> <li>Coerce numbers to strings when passed to semver.coerce()</li> <li>Add <code>rtl</code> option to coerce from right to left</li> </ul> <h2>6.1.3</h2> <ul> <li>Handle X-ranges properly in includePrerelease mode</li> </ul> <h2>6.1.2</h2> <ul> <li>Do not throw when testing invalid version strings</li> </ul> <h2>6.1.1</h2> <ul> <li>Add options support for semver.coerce()</li> <li>Handle undefined version passed to Range.test</li> </ul> <h2>6.1.0</h2> <ul> <li>Add semver.compareBuild function</li> <li>Support <code>*</code> in semver.intersects</li> </ul> <h2>6.0</h2> <ul> <li> <p>Fix <code>intersects</code> logic.</p> <p>This is technically a bug fix, but since it is also a change to behavior that may require users updating their code, it is marked as a major version increment.</p> </li> </ul> <h2>5.7</h2> <ul> <li>Add <code>minVersion</code> method</li> </ul> <h2>5.6</h2> <ul> <li>Move boolean <code>loose</code> param to an options object, with backwards-compatibility protection.</li> <li>Add ability to opt out of special prerelease version handling with the <code>includePrerelease</code> option flag.</li> </ul> <h2>5.5</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/npm/node-semver/commit/44d27bc007e4827e9b797d6145f1076c127005f2"><code>44d27bc</code></a> chore: release 6.3.1</li> <li><a href="https://github.com/npm/node-semver/commit/928e56d21150da0413a3333a3148b20e741a920c"><code>928e56d</code></a> fix: better handling of whitespace (<a href="https://redirect.github.com/npm/node-semver/issues/591">#591</a>)</li> <li><a href="https://github.com/npm/node-semver/commit/39f632690ea5b1b0d64fa913aa0f96f42b9bde32"><code>39f6326</code></a> chore: <code>@npmcli/template-oss</code><a href="https://github.com/4"><code>@4</code></a>.16.0</li> <li>See full diff in <a href="https://github.com/npm/node-semver/compare/v6.3.0...v6.3.1">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~lukekarrys">lukekarrys</a>, a new releaser for semver since your current version.</p> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/microsoft/semantic-kernel/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump semver from 6.3.0 to 6.3.1 in /samples/apps/auth-api-webapp-react (#1944) [//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [semver](https://github.com/npm/node-semver) from 6.3.0 to 6.3.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/npm/node-semver/releases">semver's releases</a>.</em></p> <blockquote> <h2>v6.3.1</h2> <h2><a href="https://github.com/npm/node-semver/compare/v6.3.0...v6.3.1">6.3.1</a> (2023-07-10)</h2> <h3>Bug Fixes</h3> <ul> <li><a href="https://github.com/npm/node-semver/commit/928e56d21150da0413a3333a3148b20e741a920c"><code>928e56d</code></a> <a href="https://redirect.github.com/npm/node-semver/pull/591">#591</a> better handling of whitespace (<a href="https://redirect.github.com/npm/node-semver/issues/591">#591</a>) (<a href="https://github.com/lukekarrys"><code>@lukekarrys</code></a>, <a href="https://github.com/joaomoreno"><code>@joaomoreno</code></a>, <a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/npm/node-semver/blob/v6.3.1/CHANGELOG.md">semver's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/npm/node-semver/compare/v6.3.0...v6.3.1">6.3.1</a> (2023-07-10)</h2> <h3>Bug Fixes</h3> <ul> <li><a href="https://github.com/npm/node-semver/commit/928e56d21150da0413a3333a3148b20e741a920c"><code>928e56d</code></a> <a href="https://redirect.github.com/npm/node-semver/pull/591">#591</a> better handling of whitespace (<a href="https://redirect.github.com/npm/node-semver/issues/591">#591</a>) (<a href="https://github.com/lukekarrys"><code>@lukekarrys</code></a>, <a href="https://github.com/joaomoreno"><code>@joaomoreno</code></a>, <a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> <h2>6.2.0</h2> <ul> <li>Coerce numbers to strings when passed to semver.coerce()</li> <li>Add <code>rtl</code> option to coerce from right to left</li> </ul> <h2>6.1.3</h2> <ul> <li>Handle X-ranges properly in includePrerelease mode</li> </ul> <h2>6.1.2</h2> <ul> <li>Do not throw when testing invalid version strings</li> </ul> <h2>6.1.1</h2> <ul> <li>Add options support for semver.coerce()</li> <li>Handle undefined version passed to Range.test</li> </ul> <h2>6.1.0</h2> <ul> <li>Add semver.compareBuild function</li> <li>Support <code>*</code> in semver.intersects</li> </ul> <h2>6.0</h2> <ul> <li> <p>Fix <code>intersects</code> logic.</p> <p>This is technically a bug fix, but since it is also a change to behavior that may require users updating their code, it is marked as a major version increment.</p> </li> </ul> <h2>5.7</h2> <ul> <li>Add <code>minVersion</code> method</li> </ul> <h2>5.6</h2> <ul> <li>Move boolean <code>loose</code> param to an options object, with backwards-compatibility protection.</li> <li>Add ability to opt out of special prerelease version handling with the <code>includePrerelease</code> option flag.</li> </ul> <h2>5.5</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/npm/node-semver/commit/44d27bc007e4827e9b797d6145f1076c127005f2"><code>44d27bc</code></a> chore: release 6.3.1</li> <li><a href="https://github.com/npm/node-semver/commit/928e56d21150da0413a3333a3148b20e741a920c"><code>928e56d</code></a> fix: better handling of whitespace (<a href="https://redirect.github.com/npm/node-semver/issues/591">#591</a>)</li> <li><a href="https://github.com/npm/node-semver/commit/39f632690ea5b1b0d64fa913aa0f96f42b9bde32"><code>39f6326</code></a> chore: <code>@npmcli/template-oss</code><a href="https://github.com/4"><code>@4</code></a>.16.0</li> <li>See full diff in <a href="https://github.com/npm/node-semver/compare/v6.3.0...v6.3.1">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~lukekarrys">lukekarrys</a>, a new releaser for semver since your current version.</p> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/microsoft/semantic-kernel/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Move dotnet/.editorconfig to dotnet/src/.editorconfig Move the .editorconfig that enforces ConfigureAwait(false) into the dotnet/src folder so that it doesn't apply to dotnet/samples. * Java: ADR to define the folder structure to be used for the Java port (#1547) ### Motivation and Context Please help reviewers and future users, providing the following information: 1. Why is this change required? The folder structure used in the Java port has diverged from that used in .Net. Some of the changes make sense i.e., are idiomatic Java and others we should review. ### Description ADR to define the folder structure to be used for the Java port. This includes a comparison of the current .Net and Java folder structures and proposal for the Java folder structure we should move towards. ### Contribution Checklist - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions) verified with `dotnet format` - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone :smile: * Copilot Chat: Display usernames in Copilot Chat (#1899) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This PR adds support for fetching user data for each user in a chat session, allowing us to display usernames instead of GUIDs in user lists. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> - User data is loaded per conversation for optimization but only fetched per user. - Fetched user data is stored and indexed globally, since users can be part of multiple chats. - User data is fetched only if the user exists in the same tenant as the active user due to AAD access restrictions, otherwise, user display name will be "External Guest". > Note: right now, external user's names will show up in the chat history since we save user names as part of the chat message, but this will be removed in future work: https://github.com/orgs/microsoft/projects/852?pane=issue&itemId=29734028  ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows SK Contribution Guidelines (https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) - [x] The code follows the .NET coding conventions (https:/…
markwallace-microsoft
pushed a commit
that referenced
this pull request
Jul 25, 2023
Apply java directory structure as defined in #1547
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
Apply java directory structure as defined in microsoft#1547
johnoliver
added a commit
to johnoliver/semantic-kernel
that referenced
this pull request
Jun 5, 2024
Apply java directory structure as defined in microsoft#1547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Please help reviewers and future users, providing the following information:
Description
ADR to define the folder structure to be used for the Java port. This includes a comparison of the current .Net and Java folder structures and proposal for the Java folder structure we should move towards.
Contribution Checklist
dotnet format