Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copilot Chat: Update to newest SK nuget #1811

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Jul 2, 2023

Motivation and Context

Update CopilotChat sample to the latest SK nuget version, absorbing breaking changes. I've done zero testing on this, other than "it builds", so we'll want to validate it before merging.
cc: @shawncal

This cleans up some cruft related to skill definitions, though there's still likely more that can be done for someone more familiar than I am with this code. I expect we'll be able to clean it up further once the exception handling changes land, as there's a lot of code dedicated to checking whether an error has occurred and short-circuiting if one has. (@SergeyMenshykh, this would be a good one to pay attention to, in particular around how exceptions propagate out of semantic functions instead of relying on manual checking of the returned context.)

Contribution Checklist

@stephentoub stephentoub requested a review from a team as a code owner July 2, 2023 20:33
@shawncal shawncal changed the title Update CopilotChat to newest SK nuget Copilot Chat: Update to newest SK nuget Jul 3, 2023
@gitri-ms gitri-ms self-assigned this Jul 3, 2023
@gitri-ms gitri-ms assigned crickman and unassigned alliscode Jul 7, 2023
@crickman
Copy link
Contributor

crickman commented Jul 8, 2023

Appreciate the update! Great to keep this in sync to show the current patterns.

@gitri-ms gitri-ms added this pull request to the merge queue Jul 10, 2023
Merged via the queue into microsoft:main with commit 7c8b239 Jul 10, 2023
13 checks passed
@stephentoub stephentoub deleted the updatecopilotchat branch July 15, 2023 17:07
golden-aries pushed a commit to golden-aries/semantic-kernel that referenced this pull request Oct 10, 2023
### Motivation and Context

Update CopilotChat sample to the latest SK nuget version, absorbing
breaking changes. **I've done zero testing on this, other than "it
builds", so we'll want to validate it before merging.**
cc: @shawncal 

This cleans up some cruft related to skill definitions, though there's
still likely more that can be done for someone more familiar than I am
with this code. I expect we'll be able to clean it up further once the
exception handling changes land, as there's a lot of code dedicated to
checking whether an error has occurred and short-circuiting if one has.
(@SergeyMenshykh, this would be a good one to pay attention to, in
particular around how exceptions propagate out of semantic functions
instead of relying on manual checking of the returned context.)

### Contribution Checklist
<!-- Before submitting this PR, please make sure: -->
- [x] The code builds clean without any errors or warnings
- [x] The PR follows SK Contribution Guidelines
(https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
- [x] The code follows the .NET coding conventions
(https://learn.microsoft.com/dotnet/csharp/fundamentals/coding-style/coding-conventions)
verified with `dotnet format`
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

Co-authored-by: Gina Triolo <51341242+gitri-ms@users.noreply.github.com>
Co-authored-by: Chris <66376200+crickman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5 participants