-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: add restore method to chat_prompt_template #2495
Merged
dluc
merged 6 commits into
microsoft:main
from
eavanvalkenburg:chat_prompt_template_restore
Aug 23, 2023
Merged
Python: add restore method to chat_prompt_template #2495
dluc
merged 6 commits into
microsoft:main
from
eavanvalkenburg:chat_prompt_template_restore
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawncal
changed the title
Ptyhon: add restore method to chat_prompt_template
Python: Ptyhon: add restore method to chat_prompt_template
Aug 18, 2023
eavanvalkenburg
changed the title
Python: Ptyhon: add restore method to chat_prompt_template
Python: add restore method to chat_prompt_template
Aug 18, 2023
python/semantic_kernel/semantic_functions/chat_prompt_template.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com>
awharrison-28
approved these changes
Aug 23, 2023
dluc
approved these changes
Aug 23, 2023
SOE-YoungS
pushed a commit
to SOE-YoungS/semantic-kernel
that referenced
this pull request
Nov 1, 2023
### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> In order to add ways to save and restore a running conversation this adds a restore method and a property to the ChatPromptTemplate class. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> 1. Add messages property which provides a view to the role, message.template tuple 2. Add restore classmethod that takes the same input as a regular init, but adds a list of tuples, it then loops through that list and adds each message. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Abby Harrison <54643756+awharrison-28@users.noreply.github.com> Co-authored-by: Devis Lucato <dluc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In order to add ways to save and restore a running conversation this adds a restore method and a property to the ChatPromptTemplate class.
Description
Contribution Checklist