Python: implemented multiple arguments for functions in templates, with named_args added #5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliomenendez
requested changes
Feb 14, 2024
|
LGTM. With that said, due to my mistake earlier with some merge issues, let's please re-create this PR against the following branch: https://github.com/microsoft/semantic-kernel/tree/python_kernel_args_latest. Sorry for the hassle. |
eavanvalkenburg
changed the base branch from
kernel_args_and_func_result
to
python_kernel_args_latest
eavanvalkenburg
force-pushed
the
named_args_blocks
branch
2 times, most recently
from
7d03f58
to
30810c6
Compare
eavanvalkenburg
force-pushed
the
python_kernel_args_latest
branch
from
fe5887e
to
a9e9085
Compare
eavanvalkenburg
force-pushed
the
named_args_blocks
branch
from
cc83134
to
a5f8c8b
Compare
moonbox3
approved these changes
Feb 21, 2024
moonbox3
approved these changes
Feb 21, 2024
moonbox3
merged commit 2a3e52a
into
microsoft:python_kernel_args_latest
2 checks passed
eavanvalkenburg
added a commit
that referenced
this pull request
Feb 22, 2024
…th named_args added (#5014) ### Motivation and Context <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This implements ADR0009 multiple arguments in a template function. Closes #5003 ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Added NamedArgBlocks class and updated codetokenizer and templatetokenizer to recognize these and implement them, add code to CodeBlock class to use it. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This implements ADR0009 multiple arguments in a template function.
Closes #5003
Description
Added NamedArgBlocks class and updated codetokenizer and templatetokenizer to recognize these and implement them, add code to CodeBlock class to use it.
Contribution Checklist