.Net: Split ClientCore class #7060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
RogerBarreto
reviewed
Jul 2, 2024
dotnet/src/Connectors/Connectors.AzureOpenAI/Core/ClientCore.ChatCompletion.cs
Outdated
Show resolved
Hide resolved
RogerBarreto
approved these changes
Jul 2, 2024
westey-m
approved these changes
Jul 2, 2024
SergeyMenshykh
merged commit f266504
into
microsoft:feature-connectors-openai
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The ClientCore class has absorbed functionality relevant to different Azure OpenAI-related services. As a first step to reduce its size, it makes sense to split it into small chunks, where each chunk would be related to a service that uses it. Later, we can move those chunks to the services themselves.
Description
This PR does the following:
ClientCoreclass intoClientCore.ChatCompletionandClientCore.Embeddingsfiles.AzureOpenAIChatCompletionServiceandAzureOpenAITextEmbeddingGenerationServiceto use the relevantClientCorepieces.AzureOpenAIClientCoreclass