Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: OpenAI V2 Connector - ChatCompletion + FC - Phase 06 #7138

Conversation

RogerBarreto
Copy link
Member

@RogerBarreto RogerBarreto commented Jul 8, 2024

Motivation and Context

This PR does the following:

  1. Migrates OpenAIChatCompletionService, ClientCore, and other model classes both use, to OpenAI SDK v2.
  2. Updates ToolCallBehavior classes to return a list of functions and function choice. This change is required because the new SDK model requires both of those for the CompletionsOptions class creation and does not allow setting them after the class is already created, as it used to allow.
  3. Adapts related unit tests to the API changes.
  4. Added netstandard2.0 as target for the UnitTest project.
  5. Rename TryGetFunctionAndArguments to TryGetOpenAIFunctionAndArguments to avoid clashing with AzureOpenAI

@RogerBarreto RogerBarreto requested a review from a team as a code owner July 8, 2024 08:58
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Jul 8, 2024
dotnet/code-coverage.ps1 Outdated Show resolved Hide resolved
@RogerBarreto RogerBarreto self-assigned this Jul 9, 2024
@RogerBarreto RogerBarreto merged commit f5b9bdc into microsoft:feature-connectors-openai Jul 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants