.Net: Vector Store: Allowing json serializer options to be passed down from vector store options and user agent string. #8296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westey-m
changed the title
RogerBarreto
approved these changes
Aug 20, 2024
@RogerBarreto Unfortunately the options passed to the azure ai search client is not exposed by the search client as a property, so you cannot verify afterwards that you passed in the right values. |
dmytrostruk
approved these changes
Aug 20, 2024
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
dmytrostruk
approved these changes
Aug 21, 2024
LudoCorporateShark
pushed a commit
to LudoCorporateShark/semantic-kernel
that referenced
this pull request
Aug 25, 2024
…n from vector store options and user agent string. (microsoft#8296) ### Motivation and Context See microsoft#8086 See microsoft#7580 To make it easier for users who are using the default construction for the azure ai search client to also use custom json serializer settings, adding this as an option to the vector store options class and using it when both when constructing the azure ai search client and the collection. Also adding the semantic kernel user agent string to the azure ai search client when constructing it. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
See #8086
See #7580
To make it easier for users who are using the default construction for the azure ai search client to also use custom json serializer settings, adding this as an option to the vector store options class and using it when both when constructing the azure ai search client and the collection.
Also adding the semantic kernel user agent string to the azure ai search client when constructing it.
Contribution Checklist