Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Update model diagnostics #8346

Merged
merged 8 commits into from
Aug 27, 2024
Merged

Python: Update model diagnostics #8346

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3cb42db
Update model diagnostics. Next: fix unit tests
TaoChenOSU Aug 23, 2024
5683fd5
Unit tests working
TaoChenOSU Aug 23, 2024
7f23c46
Add comment on semcov package
TaoChenOSU Aug 23, 2024
ffdaf6c
Remove test_tracing.py
TaoChenOSU Aug 23, 2024
9e5f765
Address comments
TaoChenOSU Aug 26, 2024
d088b28
Add model diagnostics to most AI connectors
TaoChenOSU Aug 26, 2024
7be6efa
Unit tests for two trace decorators
TaoChenOSU Aug 27, 2024
81ee053
Fix Mistral AI unit tests
TaoChenOSU Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion python/.cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@
"huggingface",
"pytestmark",
"contoso",
"opentelemetry"
"opentelemetry",
"SEMANTICKERNEL",
"OTEL"
]
}
4 changes: 3 additions & 1 deletion python/samples/demos/telemetry_with_application_insights/.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
TELEMETRY_SAMPLE_CONNECTION_STRING="..."
TELEMETRY_SAMPLE_CONNECTION_STRING="..."
SEMANTICKERNEL_EXPERIMENTAL_GENAI_ENABLE_OTEL_DIAGNOSTICS=true
SEMANTICKERNEL_EXPERIMENTAL_GENAI_ENABLE_OTEL_DIAGNOSTICS_SENSITIVE=true
2 changes: 1 addition & 1 deletion python/semantic_kernel/connectors/ai/open_ai/services/open_ai_chat_completion_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
from semantic_kernel.filters.auto_function_invocation.auto_function_invocation_context import (
AutoFunctionInvocationContext,
)
from semantic_kernel.utils.telemetry.decorators import trace_chat_completion
from semantic_kernel.utils.telemetry.model_diagnostics import trace_chat_completion

if TYPE_CHECKING:
from semantic_kernel.connectors.ai.prompt_execution_settings import PromptExecutionSettings
Expand Down
2 changes: 1 addition & 1 deletion python/semantic_kernel/connectors/ai/open_ai/services/open_ai_text_completion_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
from semantic_kernel.connectors.ai.text_completion_client_base import TextCompletionClientBase
from semantic_kernel.contents.streaming_text_content import StreamingTextContent
from semantic_kernel.contents.text_content import TextContent
from semantic_kernel.utils.telemetry.decorators import trace_text_completion
from semantic_kernel.utils.telemetry.model_diagnostics import trace_text_completion

if TYPE_CHECKING:
from semantic_kernel.connectors.ai.prompt_execution_settings import PromptExecutionSettings
Expand Down
265 changes: 0 additions & 265 deletions python/semantic_kernel/utils/telemetry/decorators.py
View file
Open in desktop

This file was deleted.

8 changes: 8 additions & 0 deletions python/semantic_kernel/utils/telemetry/model_diagnostics/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Copyright (c) Microsoft. All rights reserved.

from semantic_kernel.utils.telemetry.model_diagnostics.decorators import trace_chat_completion, trace_text_completion

__all__ = [
"trace_chat_completion",
"trace_text_completion",
]
Loading
Loading