.Net: Handle null parameter values in Handlebars positional arguments #8522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing a null parameter would previous cause a null reference exception for positional arguments. It would throw a KernelException for hash arguments. Change behavior of positional arguments to throw a KernelException to match behavior. Adds tests for both cases as well as the positive test case where a argument is passed properly
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
markwallace-microsoft
approved these changes
Sep 4, 2024
dmytrostruk
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This change makes it easier to debug issues with parameter passing using positional arguments in Handlebars templates by matching the behavior of hash arguments when a null InputVariable is passed.
Previously, the IsExpectedParameterType method would throw when it tried to check the type of a null object
Description
Passing a null parameter would previous cause a null reference exception for positional arguments. It would throw a KernelException for hash arguments. Change behavior of positional arguments to throw a KernelException to match behavior.
Adds tests for both cases as well as the positive test case where a argument is passed properly
Contribution Checklist