Python: Fix openai assistant function calling bug #8817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
eavanvalkenburg
approved these changes
Sep 16, 2024
TaoChenOSU
reviewed
Sep 16, 2024
TaoChenOSU
approved these changes
Sep 16, 2024
Python Unit Test Overview
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
We weren't properly handling the available FunctionResultContent in an OpenAI assistant if multiple tool calls were included in the chat history.
Description
Fix this issue by making sure we use the
function call contentslist as the source of truth (the model is expecting that we return the tool call ids that were sent). We then use these function call content ids to grab the corresponding function result content from the chat history and this is sent back to the model.Contribution Checklist