Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on input after text resize #1095

Closed
d-bingham opened this issue Jun 1, 2019 · 5 comments
Closed

Crash on input after text resize #1095

d-bingham opened this issue Jun 1, 2019 · 5 comments
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Conhost For issues in the Console codebase Resolution-Fix-Available It's available in an Insiders build or a release Severity-Crash Crashes are real bad news.
Milestone
Terminal v0.3

Comments

@d-bingham
Copy link
Contributor

Terminal crashes on input after a text resize.

Environment

Windows build number: [Version 10.0.18362.145]
Windows Terminal version (if applicable): 71e19cd82528d66a0a7867cbed85990cfc1685f1

Steps to reproduce

  1. Start up WSL bash in Terminal (this bug does not appear to happen in powershell or cmd)
  2. Fill the console to get the cursor at the bottom of the window

image

  1. Increase font size vi Control+MouseWheelUp

image

(note: while increasing font size, sometimes the bottom line is off the end of the terminal, which seems like it's the likely culprit...)

  1. Hit enter

image

Expected behavior

It doesn't crash.

Actual behavior

It crashes.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 1, 2019
@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Jun 3, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 3, 2019
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Needs-Tag-Fix Doesn't match tag requirements labels Jun 3, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Jun 3, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 3, 2019
@zadjii-msft
Copy link
Member

Good find here. Seems easily repro-able, so debugging and fixing shouldn't be that hard...

@DHowett-MSFT DHowett-MSFT added Product-Conhost For issues in the Console codebase and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. labels Jun 3, 2019
@DHowett-MSFT
Copy link
Contributor

Mind pressing "retry" and grabbing the stack from VS? Thanks!

@DHowett-MSFT DHowett-MSFT mentioned this issue Jun 3, 2019
Closed
@d-bingham
Copy link
Contributor Author

Stack trace of the exception thrown:

image

@d-bingham
Copy link
Contributor Author

image

image

@nlebeck nlebeck mentioned this issue Jun 12, 2019
Closed
@cinnamon-msft cinnamon-msft added the Severity-Crash Crashes are real bad news. label Jun 25, 2019
zadjii-msft added a commit that referenced this issue Jul 29, 2019
@zadjii-msft
This might fix #1095.
d34a3be 
  When we resize the conpty buffer, we'll call into
  SCREEN_INFORMATION::_InternalSetViewportSize, which will try to keep the
  commandline visible.
  However, we don't even want the commandline visible while that's happening.
  We should hide it and reflow the start of the commandline.

  I'm actually not sure this is the fix for #1095. #1095 uses WSL, which isn't
  going to be COOKED_READing.

  Aditionally, the commandline can end up in some weird places after this. Like
  when restoring down with a commandline wider than the restored width, the
  commandline will appear one line below where it should. That might be a side
  effect of the rest of the changes I'm prototyping (for #1795)
@zadjii-msft zadjii-msft mentioned this issue Jul 30, 2019
Merged
1 task
@zadjii-msft
Copy link
Member

I'm almost 100% certain #2149 did end up fixing this. Hooray!

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Aug 14, 2019
@zadjii-msft zadjii-msft removed this from the Terminal 1908.1 milestone Aug 14, 2019
@zadjii-msft zadjii-msft added this to the Terminal v0.3 milestone Aug 14, 2019
@zadjii-msft zadjii-msft added the Resolution-Fix-Available It's available in an Insiders build or a release label Aug 14, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 14, 2019
@zadjii-msft zadjii-msft removed the Help Wanted We encourage anyone to jump in on these. label Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Conhost For issues in the Console codebase Resolution-Fix-Available It's available in an Insiders build or a release Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v0.3
Development

No branches or pull requests
4 participants
@DHowett-MSFT @zadjii-msft @d-bingham @cinnamon-msft