Sending negative values to ResizePseudoConsole returns S_OK

[ZoeyR]

Environment

Windows build number: 18363,418
Windows Terminal version (if applicable):

Any other software?

Steps to reproduce

Call ResizePseudoConsole with negative values stored in the passed COORD structure.

Expected behavior

returned HRESULT should indicate failure since a pty cannot have a negative size

Actual behavior

returned HRESULT indicates success.

[miniksa]

terminal/src/winconpty/winconpty.cpp

Lines 201 to 215 in 388b975

	HRESULT _ResizePseudoConsole(_In_ const PseudoConsole* const pPty, _In_ const COORD size)
	{
	if (pPty == NULL)
	{
	return E_INVALIDARG;
	}
	unsigned short signalPacket[3];
	signalPacket[0] = PTY_SIGNAL_RESIZE_WINDOW;
	signalPacket[1] = size.X;
	signalPacket[2] = size.Y;
	BOOL fSuccess = WriteFile(pPty->hSignal, signalPacket, sizeof(signalPacket), NULL, NULL);
	return fSuccess ? S_OK : HRESULT_FROM_WIN32(GetLastError());
	}

The COORD which has two signed SHORTs is being pushed into a structure of unsigned short and apparently nothing is complaining or validating that.

[ghost]

🎉This issue was addressed in #3936, which has now been successfully released as Windows Terminal Preview v0.8.10091.0.:tada:

Handy links:

• Release Notes
• Store Download