Fix VS profile command generation #15439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
|
Wait, why doesn't it work the way it is? |
|
OH, IT'S THE QUOTE. FRICK. SORRY. |
DHowett
approved these changes
May 25, 2023
|
Yep, the resulting path makes it more obvious: I'll edit the PR description. |
zadjii-msft
approved these changes
May 25, 2023
zadjii-msft
added
the
AutoMerge
DHowett
pushed a commit
that referenced
this pull request
May 25, 2023
This regressed in f06cd17. It seems like the change went untested, because it appends an extra " after -startdir=none. This changeset also avoids calling `append()` twice. Closes #15436 ## Validation Steps Performed * VS Developer Command Prompt works ✅ (cherry picked from commit 0073e36) Service-Card-Id: 89324745 Service-Version: 1.18
DHowett
pushed a commit
that referenced
this pull request
May 25, 2023
This regressed in f06cd17. It seems like the change went untested, because it appends an extra " after -startdir=none. This changeset also avoids calling `append()` twice. Closes #15436 ## Validation Steps Performed * VS Developer Command Prompt works ✅ (cherry picked from commit 0073e36) Service-Card-Id: 89324784 Service-Version: 1.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed in f06cd17. It seems like the change went untested,
because it appends an extra " after -startdir=none.
This changeset also avoids calling
append()twice.Closes #15436
Validation Steps Performed