env: always expand PATH vars #15444
Merged
env: always expand PATH vars #15444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
zadjii-msft
approved these changes
May 26, 2023
lhecker
approved these changes
May 26, 2023
Co-authored-by: Mike Griese <migrie@microsoft.com>
|
Thanks @sotteson1 for fixing this! Great find! |
DHowett
pushed a commit
that referenced
this pull request
May 26, 2023
Make sure we always expand path env vars, even if they're REG_SZ in the registry. ## Detailed Description of the Pull Request / Additional comments On some systems path vars are REG_SZ instead of REG_EXPAND_SZ. We need to make sure we always expand them. We looked at the system code, and it also makes to sure to always expand them. ## Validation Steps Performed Built locally and made sure the problem went away. Also stepped through in the debugger to make sure things were working correctly. Closes #15442 (cherry picked from commit 709189d) Service-Card-Id: 89337408 Service-Version: 1.18
|
One might wonder why on some systems path vars are |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we always expand path env vars, even if they're REG_SZ in the registry.
Detailed Description of the Pull Request / Additional comments
On some systems path vars are REG_SZ instead of REG_EXPAND_SZ. We need to make sure we always expand them. We looked at the system code, and it also makes to sure to always expand them.
Validation Steps Performed
Built locally and made sure the problem went away. Also stepped through in the debugger to make sure things were working correctly.
Closes #15442