Theoretical fix for some crashes #15457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
reviewed
May 26, 2023
| // message loop, where it'll end up asking XAML something that XAML is no | ||
| // longer able to answer. | ||
| SetWindowLongPtr(_window.get(), GWLP_USERDATA, (LONG_PTR)nullptr); | ||
|
|
||
| if (_source) | ||
| { | ||
| _source.Close(); |
There was a problem hiding this comment.
I just realized... When we do winrt::detach_abi above, it'll null out _source and so we won't call Close() anymore. Is that intentional or should we just remove Close()?
There was a problem hiding this comment.
I mean, yea - but that's still only for Windows 10, and I'm blowing that bodge away in #15424 anyways
lhecker
approved these changes
May 26, 2023
DHowett
reviewed
May 26, 2023
fine fine fine
DHowett
approved these changes
May 26, 2023
DHowett
pushed a commit
that referenced
this pull request
May 26, 2023
RE: * #15454 * MSFT:44725712 "WindowsTerminal.exe!NonClientIslandWindow::OnSize" * MSFT:44754014 "NonClientIslandWindow::GetTotalNonClientExclusiveSize" I think this should fix all of those, but I want to ship and verify live, since I can't repro this locally. (cherry picked from commit 8611d90) Service-Card-Id: 89337669 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE:
I think this should fix all of those, but I want to ship and verify live, since I can't repro this locally.