Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only update the icon of a tab it the icon actually _changed_ #2376

Merged
merged 4 commits into from
Aug 14, 2019
Merged

Only update the icon of a tab it the icon actually _changed_ #2376

merged 4 commits into from
Aug 14, 2019

Commits on Aug 9, 2019

  1. Only update the icon of a tab it the icon actually _changed_ 

      * fixes #1333
  * Also tangentially fixes #2339
    @zadjii-msft
    zadjii-msft committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    b94c767 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2019

  1. Make Profile::GetIcon always expand env vars

    @zadjii-msft
    zadjii-msft committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    5083493 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2019

  1. Move this to a helper to make Dustin happy

    @zadjii-msft
    zadjii-msft committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    b255078 View commit details
    Browse the repository at this point in the history

  2. Make this actually catch the exception, and clean it up a bit.

    @zadjii-msft
    zadjii-msft committed Aug 14, 2019
    Configuration menu
    Copy the full SHA
    396fa52 View commit details
    Browse the repository at this point in the history