Add support for the HPR and VPR escape sequences #4297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
approved these changes
Jan 20, 2020
zadjii-msft
added
Area-VT
ghost
requested review from
miniksa,
carlos-zamora,
DHowett-MSFT and
leonMSFT
DHowett-MSFT
approved these changes
Jan 20, 2020
|
@msftbot merge this in 24 hours |
ghost
added
the
AutoMerge
|
Hello @DHowett-MSFT! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Once again, thanks for the contribution! This pull request was included in a set of conhost changes that was just |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This PR adds support for the
HPRandVPRescape sequences from the VT510 terminal.HPRmoves the cursor position forward by a given number of columns, andVPRmoves the cursor position downward by a given number of rows. They're similar in function to theCUFandCUDescape sequences, except that they're not constrained by the scrolling margins.References
#3628 provided the new
_CursorMovePositionmethod that made these operations possiblePR Checklist
Detailed Description of the Pull Request / Additional comments
Most of the implementation is in the new
_CursorMovePositionmethod that was created in PR #3628, so all we're really doing here is hooking up the escape sequences to call that method with the appropriate parameters.Validation Steps Performed
I've extended the existing state machine tests for CSI cursor movement to confirm that the
HPRandVPRsequences are dispatched correctly, and also added screen buffer tests to make sure the movement is clamped by the screen boundaries and not the scrolling margins (we don't yet support horizontal margins, but the test is at least in place for when we do eventually add that support).I've also checked the
HPRandVPRtests in Vttest (under Test non-VT100 / ISO-6429 cursor-movement) and confirmed that they are now working as expected.