Shut down all controls under a tab before we remove it from the list #4337
Conversation
This commit introduces a new recursive pane shutdown that will give all controls under a tab a chance to clean up their state before beign detached from the UI. It also reorders the call to LastTabClosed() so that the application does not exit before the final connections are terminated. It also teaches TSFInputControl how to shut down to avoid a dramatic platform bug. Fixes #4159. Fixes #4336.
DHowett-MSFT
added
the
Severity-Blocking
|
It will not result in Pane::Close being called -- the pane remains in the UI tree until it's otherwise removed, but all of its controls and connections go inert. |
So if the control cleanly closes though, like the pre- |
|
Yes. If the control is closed and removed from the UI hierarchy (because its leaf pane has been resorbed by its parent), its |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
plz /azp run |
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
merged commit …4337) This commit introduces a new recursive pane shutdown that will give all controls under a tab a chance to clean up their state before beign detached from the UI. It also reorders the call to LastTabClosed() so that the application does not exit before the final connections are terminated. It also teaches TSFInputControl how to shut down to avoid a dramatic platform bug. Fixes #4159. Fixes #4336. ## PR Checklist * [x] CLA signed * [x] I've discussed this with core contributors already. ## Validation Steps Performed Validated through manual terminal teardown within and without the debugger, given a crazy number of panes and tabs. (cherry picked from commit 82f302b)
|
🎉 Handy links: |
This commit introduces a new recursive pane shutdown that will give all
controls under a tab a chance to clean up their state before beign
detached from the UI. It also reorders the call to LastTabClosed() so
that the application does not exit before the final connections are
terminated.
It also teaches TSFInputControl how to shut down to avoid a dramatic
platform bug.
Fixes #4159.
Fixes #4336.
PR Checklist
Validation Steps Performed
Validated through manual terminal teardown within and without the debugger, given a crazy number of panes and tabs.