Configure CLI11 to stuff all unknown positionals into the cmdline #4388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where "wt -d C: wsl -d Alpine" would be parsed as "wt -d C: -d Alpine wsl" and rejected as invalid due to the repeated -d. It also fixes support for the option parsing terminator, --, in all command lines. Fixes #4277.
DHowett-MSFT
force-pushed
the
dev/duhowett/why_must_you_parse_--_differently_friendo
branch
from
ae4f786
to
bfa6ade
Compare
|
The new test passes, but the |
what? no, I would never not run the tests like that O_o
/s
|
zadjii-msft
approved these changes
Jan 28, 2020
miniksa
reviewed
Jan 28, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
miniksa
approved these changes
Jan 29, 2020
|
I learned from the CLI11 folks that we don't actually need the string+vector version |
DHowett-MSFT
deleted the
dev/duhowett/why_must_you_parse_--_differently_friendo
branch
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where "wt -d C: wsl -d Alpine" would be
parsed as "wt -d C: -d Alpine wsl" and rejected as invalid due to the
repeated -d. It also fixes support for the option parsing terminator,
--, in all command lines.
Fixes #4277.
References
CLIUtils/CLI11#417
PR Checklist
--startingDirectoryto a WSLwt.execommand #4277Validation Steps
Tests, manual wailing.