Implement Hard Reset for Terminal #4909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary of the Pull Request This _actually_ implements `\033c` ([RIS](https://vt100.net/docs/vt220-rm/chapter4.html)) for the Windows Terminal. I thought I had done this in #4433, but that PR actually only passthrough'd `\x1b[3J`. I didn't realize at the time that #2715 was mostly about hard reset, not erase scrollback. Not only should conpty pass through RIS, but the Terminal should also be prepared to actually handle that sequence. So this PR adds that support as well. ## References * #4433: original PR I thought fixed this. ## PR Checklist * [x] Closes #2715 for real this time * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Actually tested `printf \033c` in the Terminal this time
zadjii-msft
added
Area-VT
DHowett-MSFT
approved these changes
Mar 13, 2020
Comment on lines
+417
to
+424
| // if (success) | ||
| // { | ||
| // success = SetOriginMode(false); // Absolute cursor addressing. | ||
| // } | ||
| // if (success) | ||
| // { | ||
| // success = SetAutoWrapMode(true); // Wrap at end of line. | ||
| // } |
There was a problem hiding this comment.
Okay, i accept the reason for these comments
carlos-zamora
approved these changes
Mar 13, 2020
Co-Authored-By: Carlos Zamora <carlos.zamora@microsoft.com>
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This actually implements
\033c(RIS) for the Windows Terminal.
I thought I had done this in #4433, but that PR actually only passthrough'd
\x1b[3J. I didn't realize at the time that #2715 was mostly about hard reset,not erase scrollback.
Not only should conpty pass through RIS, but the Terminal should also be
prepared to actually handle that sequence. So this PR adds that support as well.
References
CSI 3 Jin Conpty #4433: original PR I thought fixed this.PR Checklist
Validation Steps Performed
Actually tested
printf \033cin the Terminal this time