Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable incremental rendering. #5365

Closed
wants to merge 1 commit into from
Closed

Disable incremental rendering. #5365

wants to merge 1 commit into from

Conversation

miniksa
Copy link
Member

@miniksa miniksa commented Apr 15, 2020

Summary of the Pull Request

Disables incremental rendering as we cannot reach parity between normal and High DPI by 1.0 ship, there are some outstanding longtail issues with the incremental rendering around fonts and certain applications, and the solutions to these problems require broad architectural change to resolve.

PR Checklist

Validation Steps Performed

  • - Ran it and dragged it between two DPI monitors
  • - Ran some commands outputting a bunch of text, including to the bottom of the circular buffer.
  • - Tried vim in ubuntu via WSL

@miniksa miniksa self-assigned this Apr 15, 2020
@miniksa
Copy link
Member Author

miniksa commented Apr 15, 2020

FYI, not doing a full revert because I caught a bunch of other small issues including some locking issues in the big #5185 PR that we don't want to lose.

zadjii-msft
zadjii-msft approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

DHowett-MSFT
DHowett-MSFT approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

DHowett-MSFT
DHowett-MSFT suggested changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@DHowett-MSFT DHowett-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do we say to the god of death?

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 15, 2020
@DHowett-MSFT
Copy link
Contributor

Blocking pending discussion.

@miniksa miniksa marked this pull request as draft April 15, 2020 20:42
@miniksa
Copy link
Member Author

miniksa commented Apr 15, 2020

Drafting this because reasons.

@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 15, 2020
@DHowett-MSFT
Copy link
Contributor

Only disabling this for 0.11. Closing the PR into master.

@oising
Copy link
Collaborator

oising commented Apr 21, 2020

Crying just because

@DHowett DHowett deleted the dev/miniksa/sadness branch October 26, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett-MSFT DHowett-MSFT DHowett-MSFT requested changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

Assignees

@miniksa miniksa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miniksa @DHowett-MSFT @oising @zadjii-msft