Trigger scroll on scrolled selection

[carlos-zamora]

Summary of the Pull Request

We accidentally missed switching one TriggerRedrawAll to TriggerScroll. This does that.

References

#5185 - applies logic from this PR

PR Checklist

• Closes Multiple Selections Rendered with Search Box #5756

Validation Steps Performed

Followed bug repro steps.

[zadjii-msft]

I'm kinda shocked that this fixes #5756 but ¯\_(ツ)_/¯

[DHowett-MSFT]

Investigate to make sure that callers of SelectNewRegion call it under lock.

[carlos-zamora]

@DHowett-MSFT
Trace for SelectNewRegion:

  TermControl::_Search
  --> LockForWriting()
  --> Search::Select()
      --> Terminal::SelectNewRegion()
          --> // Scroll Logic
          --> TriggerScroll

The only other time SelectNewRegion is called is via UiaTextRange::Select, where we start off by doing...

    _pData->LockConsole();
    auto Unlock = wil::scope_exit([&]() noexcept {
        _pData->UnlockConsole();
    });

So, I think that covers it. Though I do agree with @zadjii-msft that this doesn't seem like the complete solution. hmm.

[DHowett-MSFT]

Sorry, I'm missing something here. Does Search::Select() end up taking the lock?

[carlos-zamora]

Sorry, I'm missing something here. Does Search::Select() end up taking the lock?

We lock in TermControl::Select() before calling Search::Select. So yes?

[DHowett-MSFT]

Excellent.

[DHowett-MSFT]

Just to be sure: you had a 100% surefire repro before this, and now you don't? Wow

[miniksa]

Yep.

[carlos-zamora]

Just to be sure: you had a 100% surefire repro before this, and now you don't? Wow

Yep. I tested it on 0.11 and this branch side-by-side. I'm surprised too haha.

[ghost]

🎉Windows Terminal Release Candidate v0.11.1333.0 (1.0rc2) has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download