Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description, WorkItem, CssIteration, CssProjectStructure should *NOT* be treated as traits. #482

Merged
merged 3 commits into from
Sep 17, 2018
Merged

Description, WorkItem, CssIteration, CssProjectStructure should *NOT* be treated as traits. #482

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fc548e
Attributes like Description should not inherit from TestPropertyAttri…
singhsarab Sep 4, 2018
c0ef4ee
Merge branch 'master' into DescriptionTraitFix
singhsarab Sep 17, 2018
660168c
Merge branch 'master' into DescriptionTraitFix
singhsarab Sep 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions src/TestFramework/MSTest.Core/Attributes/VSTestAttributes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,6 @@ public sealed class AssemblyCleanupAttribute : Attribute
{
}

#region Description attributes

/// <summary>
/// Test Owner
/// </summary>
Expand Down Expand Up @@ -234,14 +232,13 @@ public PriorityAttribute(int priority)
/// Description of the test
/// </summary>
[AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
public sealed class DescriptionAttribute : TestPropertyAttribute
public sealed class DescriptionAttribute : Attribute
{
/// <summary>
/// Initializes a new instance of the <see cref="DescriptionAttribute"/> class to describe a test.
/// </summary>
/// <param name="description">The description.</param>
public DescriptionAttribute(string description)
: base("Description", description)
{
this.Description = description;
}
Expand All @@ -256,14 +253,13 @@ public DescriptionAttribute(string description)
/// CSS Project Structure URI
/// </summary>
[AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
public sealed class CssProjectStructureAttribute : TestPropertyAttribute
public sealed class CssProjectStructureAttribute : Attribute
{
/// <summary>
/// Initializes a new instance of the <see cref="CssProjectStructureAttribute"/> class for CSS Project Structure URI.
/// </summary>
/// <param name="cssProjectStructure">The CSS Project Structure URI.</param>
public CssProjectStructureAttribute(string cssProjectStructure)
: base("CssProjectStructure", cssProjectStructure)
{
this.CssProjectStructure = cssProjectStructure;
}
Expand All @@ -278,14 +274,13 @@ public CssProjectStructureAttribute(string cssProjectStructure)
/// CSS Iteration URI
/// </summary>
[AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
public sealed class CssIterationAttribute : TestPropertyAttribute
public sealed class CssIterationAttribute : Attribute
{
/// <summary>
/// Initializes a new instance of the <see cref="CssIterationAttribute"/> class for CSS Iteration URI.
/// </summary>
/// <param name="cssIteration">The CSS Iteration URI.</param>
public CssIterationAttribute(string cssIteration)
: base("CssIteration", cssIteration)
{
this.CssIteration = cssIteration;
}
Expand All @@ -300,14 +295,13 @@ public CssIterationAttribute(string cssIteration)
/// WorkItem attribute; used to specify a work item associated with this test.
/// </summary>
[AttributeUsage(AttributeTargets.Method, AllowMultiple = true)]
public sealed class WorkItemAttribute : TestPropertyAttribute
public sealed class WorkItemAttribute : Attribute
{
/// <summary>
/// Initializes a new instance of the <see cref="WorkItemAttribute"/> class for the WorkItem Attribute.
/// </summary>
/// <param name="id">The Id to a work item.</param>
public WorkItemAttribute(int id)
: base("WorkItem", id.ToString(CultureInfo.CurrentCulture))
{
this.Id = id;
}
Expand All @@ -318,8 +312,6 @@ public WorkItemAttribute(int id)
public int Id { get; private set; }
}

#endregion

/// <summary>
/// Timeout attribute; used to specify the timeout of a unit test.
/// </summary>
Expand Down