Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for prettier 2.0 #2760

Closed
timotheeguerin opened this issue Dec 18, 2023 · 1 comment · Fixed by #2956
Closed

Drop support for prettier 2.0 #2760

timotheeguerin opened this issue Dec 18, 2023 · 1 comment · Fixed by #2956
Labels
triaged:core
Milestone
[2024] March

Comments

@timotheeguerin
Copy link
Member

timotheeguerin commented Dec 18, 2023 •
edited
Loading

Prettier 3.0 has been out for some time and some of the apis are now deprecated. However updating to the newer api will break anyone that is using our plugin with prettier 2.0.

Apis that should be migrated:

  • .getValue() -> .node

If we think keeping prettier 2.0 support is important(not sure why) then we could maybe do a custom wrapper that calls the right function.
@markcowl markcowl added this to the [2024] February milestone Dec 18, 2023
@markcowl
Copy link
Contributor

est: 2

@timotheeguerin timotheeguerin mentioned this issue Feb 26, 2024
Merged
timotheeguerin added a commit that referenced this issue Feb 28, 2024
@timotheeguerin
Remove prettier2.0 support in prettier plugin (#2956)
628517e 
fix #2760 
`@typespec/prettier-plugin-typespec` dropped support for prettier 2.0.
Update to 3.0 to use the new version of the plugin.
markcowl pushed a commit to markcowl/cadl that referenced this issue Mar 8, 2024
@timotheeguerin @markcowl
Remove prettier2.0 support in prettier plugin (microsoft#2956)
a239d29 
fix microsoft#2760
`@typespec/prettier-plugin-typespec` dropped support for prettier 2.0.
Update to 3.0 to use the new version of the plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triaged:core
Projects
None yet
Milestone
[2024] March
Development

Successfully merging a pull request may close this issue.

Remove prettier2.0 support in prettier plugin timotheeguerin/typespec
2 participants
@timotheeguerin @markcowl