Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Augmenting a template declaration with a decorator from a library doesn't seem to use value marshalling #3211

Closed
timotheeguerin opened this issue Apr 23, 2024 · 0 comments · Fixed by #3212
Closed

Augmenting a template declaration with a decorator from a library doesn't seem to use value marshalling #3211

timotheeguerin opened this issue Apr 23, 2024 · 0 comments · Fixed by #3212
Assignees
@timotheeguerin
Labels
bug Something isn't working triaged:core

Comments

@timotheeguerin
Copy link
Member

This doesn't seem to affect standard library decorators for some reason

Playground Link
@timotheeguerin timotheeguerin self-assigned this Apr 23, 2024
This was referenced Apr 23, 2024
Merged
Closed
github-merge-queue bot pushed a commit that referenced this issue Apr 23, 2024
@timotheeguerin
Fix: augmenting template property didn't resolve declaration (#3212)
e09af82 
fix #3211
Problem was we were checking the decorator declaration passing the
`mapper` this mean the checker was thinking we were defining this
decorator declaration in a template instance(which is not possible)
This resulted in the argument marshaling to not happen as it will only
happen when there is a valueof constraint
@markcowl markcowl added triaged:core bug Something isn't working and removed needs-area labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timotheeguerin timotheeguerin

Labels
bug Something isn't working triaged:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: augmenting template property didn't resolve declaration timotheeguerin/typespec
2 participants
@timotheeguerin @markcowl