Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: JSONSchema emitter ignores decorator metadata is ignored on union variants #3391

Closed
4 tasks done
Veetaha opened this issue May 17, 2024 · 0 comments · Fixed by #3398
Closed
4 tasks done

[Bug]: JSONSchema emitter ignores decorator metadata is ignored on union variants #3391

Veetaha opened this issue May 17, 2024 · 0 comments · Fixed by #3398
Labels
bug Something isn't working emitter:json-schema
Milestone
[2024] June

Comments

@Veetaha
Copy link
Contributor

Veetaha commented May 17, 2024 •
edited
Loading

Describe the bug

It seems like decorator metadata I attach to a union variant is ignored. For example, if I write documentation with @doc or a doc comment it's silently ignored. I tried looking for a workaround with a custom decorator, but I couldn't find one.

image

Reproduction

Playground link

Checklist
@Veetaha Veetaha added the bug Something isn't working label May 17, 2024
@Veetaha Veetaha mentioned this issue May 18, 2024
Merged
@markcowl markcowl added this to the [2024] June milestone May 20, 2024
github-merge-queue bot pushed a commit that referenced this issue May 20, 2024
@Veetaha @timotheeguerin
Fix handling decorators for union variants in JSONSchema emitter (#3398)
ccd67cf 
Fixes #3391

Also refactored a minor problem of using a deprecated reexport of
`DuplicateTracker`, not it's referenced from `@typespec/compiler/utils`
directly, and another small typo.

---------

Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
Co-authored-by: Timothee Guerin <tiguerin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working emitter:json-schema
Projects
None yet
Milestone
[2024] June
Development

Successfully merging a pull request may close this issue.

Fix handling decorators for union variants in JSONSchema emitter Veetaha/typespec
2 participants
@markcowl @Veetaha