Feature: Code fixes #2888
Merged
Feature: Code fixes #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All changed packages have been documented. |
markcowl
reviewed
Feb 5, 2024
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/2888/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/2888/ |
timotheeguerin
commented
Feb 9, 2024
timotheeguerin
requested review from
bterlson,
daviwil and
allenjzhang
as code owners
markcowl
reviewed
Mar 1, 2024
|
|
||
| async function toEqual(expectedCode: string) { | ||
| const diagnostics = await diagnose(code); | ||
| const codefix = diagnostics[0].codefixes?.find((x) => x.id === fixId); |
There was a problem hiding this comment.
This is expected to be used only when there is a single diagnostic?
There was a problem hiding this comment.
Yeah the expectation is you emit a single linter warning and apply the code fix on it
There was a problem hiding this comment.
If we endup having cases where there is multiple diagnostic always emitted, I think then we can add a extra option to choose which one
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
markcowl
approved these changes
Mar 5, 2024
markcowl
added a commit
to markcowl/cadl
that referenced
this pull request
Mar 8, 2024
closes microsoft#615 ## Code fixes added ### Suppress  ### `number` -> `float64` typo fix  ### Enum to extensible enum in typespec-azure Azure/typespec-azure#258 --------- Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #615
Code fixes added
Suppress
number->float64typo fixEnum to extensible enum in typespec-azure
Azure/typespec-azure#258