Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash with deleted file #2934

Merged
merged 2 commits into from
Feb 17, 2024
Merged

Fix crash with deleted file #2934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6ee8e5
Fix crash with deleted file
timotheeguerin Feb 17, 2024
841bb1d
Create fix-crash-deleted-file-2024-1-17-1-27-24.md
timotheeguerin Feb 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .chronus/changes/fix-crash-deleted-file-2024-1-17-1-27-24.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
# Change versionKind to one of: internal, fix, dependencies, feature, deprecation, breaking
changeKind: fix
packages:
- "@typespec/compiler"
---

[IDE] Fix issue when deleting an open file outside the IDE that would crash the language server
10 changes: 9 additions & 1 deletion packages/compiler/src/core/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,15 @@ export function mapEquals<K, V>(
}

export async function getNormalizedRealPath(host: CompilerHost, path: string) {
return normalizePath(await host.realpath(path));
try {
return normalizePath(await host.realpath(path));
} catch (error: any) {
// This could mean the file got deleted but VSCode still has it in memory. So keep the original path.
if (error.code === "ENOENT") {
return normalizePath(path);
}
throw error;
}
}

export interface FileHandlingOptions {
Expand Down
Loading