Add getOpenAPI3 to OpenAPI3 emitter
#2950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bterlson
requested review from
daviwil,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
All changed packages have been documented. |
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/2950/ Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/2950/ |
timotheeguerin
approved these changes
Feb 23, 2024
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
timotheeguerin
approved these changes
Feb 24, 2024
packages/openapi3/src/types.ts
Outdated
| version: string; | ||
|
|
||
| /** The diagnostics created for this version. */ | ||
| readonly diagnostics: Readonly<Diagnostic[]>; |
There was a problem hiding this comment.
Suggested change
| readonly diagnostics: Readonly<Diagnostic[]>; | |
| readonly diagnostics: readonly Diagnostic[]; |
also should all the props be readonly?
Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
…into openapi3-function
timotheeguerin
approved these changes
Feb 26, 2024
markcowl
pushed a commit
to markcowl/cadl
that referenced
this pull request
Mar 8, 2024
This function is useful when you want to work with the OpenAPI 3 directly, or don't want to write it to disk for some reason. --------- Co-authored-by: Timothee Guerin <timothee.guerin@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is useful when you want to work with the OpenAPI 3 directly, or don't want to write it to disk for some reason. In my case, I am going to be emitting clients with Kiota, and I want to handle writing the OpenAPI myself, and keep it as an internal implementation detail.