Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds public function for setting info object directly #3626

Merged
merged 27 commits into from
Jul 9, 2024

Conversation

irvinesunday
Copy link
Contributor

Fixes #3446

By adding support for extending namespace, we will be able to add extensions to the OpenAPI info object via the new function - setNamespaceExtension(...)

Copy link
Member

@timotheeguerin timotheeguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think setNamrspaceextension is the correct name setExyensiom already able to be applied to a namespace. The problem here is that we don't have a type that map to info.

@irvinesunday irvinesunday changed the title Adds support for extending namespace Adds public function for setting info object directly Jul 4, 2024
@irvinesunday
Copy link
Contributor Author

irvinesunday commented Jul 9, 2024

@timotheeguerin your committed suggested change has broken build:

export function setInfo(
  program: Program,
  entity: Namespace,
  data: AdditionalInfo & Record<ExtensionKey, unknown>
) { }

@timotheeguerin timotheeguerin added this pull request to the merge queue Jul 9, 2024
Merged via the queue into microsoft:main with commit 9fda9cd Jul 9, 2024
18 checks passed
@irvinesunday
Copy link
Contributor Author

@timotheeguerin thanks a bunch for your input here 🙏🏾
When do you think the next release will be going out?

@irvinesunday irvinesunday deleted the irvine/set-info-extension branch July 11, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for extending OpenApi info object via extensions
2 participants