Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply openapi3 extension on Security schemes #3732

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Apply openapi3 extension on Security schemes #3732

merged 4 commits into from
Jul 2, 2024

Conversation

timotheeguerin
Copy link
Member

fix #3555

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 2, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/http
  • ✅ @typespec/openapi3
Show changes

@typespec/openapi3 - feature ✏️

Apply openapi3 extension on Security schemes

@typespec/http - feature ✏️

Expose model property on HttpAuth to retrieve original type used to define security scheme

@azure-sdk
Copy link
Collaborator

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/3732/

Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/3732/

@timotheeguerin timotheeguerin added this pull request to the merge queue Jul 2, 2024
Merged via the queue into microsoft:main with commit 97d426e Jul 2, 2024
21 checks passed
@timotheeguerin timotheeguerin deleted the set-openapi3-extension-security-schemes branch July 2, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisradek chrisradek chrisradek approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenAPI emitter: @extension should also be applied to securitySchemes
3 participants
@timotheeguerin @azure-sdk @chrisradek