Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsp-openapi3 - update to group items by namespace when separated by dot, and escaped otherwise invalid identifiers #3844

Merged
merged 5 commits into from
Jul 16, 2024
Merged

tsp-openapi3 - update to group items by namespace when separated by dot, and escaped otherwise invalid identifiers #3844

merged 5 commits into from
Jul 16, 2024

Conversation

chrisradek
Copy link
Member

Fixes #3810 and replaces #3808

This PR does 2 things:

  1. Groups operations/models into namespaces based on the dots in their schema names/operationIds.
  2. Escapes invalid identifiers by surrounding them with backticks.

@chrisradek chrisradek mentioned this pull request Jul 16, 2024
Closed
@azure-sdk
Copy link
Collaborator

All changed packages have been documented.

  • ✅ @typespec/openapi3
Show changes

@typespec/openapi3 - feature ✏️

Updates tsp-openapi3 to escape identifiers that would otherwise be invalid, and automatically resolve namespaces for schemas with dots in their names.

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@timotheeguerin timotheeguerin added this pull request to the merge queue Jul 16, 2024
Merged via the queue into microsoft:main with commit ae229b2 Jul 16, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenAPI3 to TSP should try to group items by namespace when seperated by a .
3 participants
@chrisradek @azure-sdk @timotheeguerin