Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support completion for template parameter extending model or object value #3906

Merged
merged 7 commits into from
Jul 23, 2024
Merged

Support completion for template parameter extending model or object value #3906

merged 7 commits into from
Jul 23, 2024

Conversation

RodgeFu
Copy link
Contributor

@RodgeFu RodgeFu commented Jul 19, 2024

fix #3778

@RodgeFu RodgeFu changed the title Complete template parameter ref Support completion for template parameter extending model or object value Jul 19, 2024
@RodgeFu RodgeFu added the ide Issues for VS, VSCode, Monaco, etc. label Jul 19, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 19, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/compiler
Show changes

@typespec/compiler - feature ✏️

Support completion for template parameter extending model or object value,> ,> Example,> tsp,> model User<T extends {name: string, age: int16}> {,> },> alias user = User< {┆,> | [age],> | [name],>

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@timotheeguerin timotheeguerin added this pull request to the merge queue Jul 23, 2024
Merged via the queue into microsoft:main with commit 96c81c5 Jul 23, 2024
22 checks passed
This was referenced Aug 29, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timotheeguerin timotheeguerin timotheeguerin approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

Assignees
No one assigned
Labels
ide Issues for VS, VSCode, Monaco, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autocomplete of object property doesn't work for templates
3 participants
@RodgeFu @azure-sdk @timotheeguerin